Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16329 chk: maintenance mode after checking pool with dryrun #14984

Merged
merged 1 commit into from
Sep 25, 2024
Merged

DAOS-16329 chk: maintenance mode after checking pool with dryrun #14984

merged 1 commit into from
Sep 25, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Aug 22, 2024 •
edited
Loading

Sometimes, after system shutdown unexpectedly, the users may expect to check their critical data under some kind of maintenance mode. Under such mode, no user data can be modified or moved or aggregated. That will guarantee no further potential (DAOS logic caused) damage can happen during the check.

For such purpose, we will enhance current DAOS CR logic with --dryrun option to allow the pool (after check) to be opened as immutable with disabling some mechanism that may potentially cause data modification or movement (such as rebuild or aggregation).

Under such mode, if client wants to connect to the pool, the read-only option must be specified. Similarly for opening container in such pool.

Test-tag: pr cat_recov
Allow-unstable-test: true

Signed-off-by: Fan Yong [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

Ticket title is 'Maintenance mode after CR checking the pool with dryrun option'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16329

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14984/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14984/1/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16329_1 branch from 030f098 to 0ede219 Compare August 23, 2024 03:15
@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14984/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14984/2/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16329_1 branch from 0ede219 to c07ad29 Compare August 23, 2024 04:39
@Nasf-Fan Nasf-Fan marked this pull request as ready for review August 25, 2024 15:32
@Nasf-Fan Nasf-Fan requested review from a team as code owners August 25, 2024 15:32
daltonbohning
daltonbohning previously requested changes Aug 26, 2024
View reviewed changes
src/tests/ftest/cart/util/cart_logtest.py Outdated
@@ -209,7 +209,7 @@ def subtract(self, val):
"DER_NOTLEADER(-2008): 'Not service leader'")

# Functions that are never reported as errors.
IGNORED_FUNCTIONS = ('sched_watchdog_post', 'rdb_timerd')
IGNORED_FUNCTIONS = ('sched_watchdog_post', 'rdb_timerd', 'cont_open')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we ignoring cont_open here instead of fixing the errors? And what are the errors we're ignoring?

kjacque
kjacque requested changes Aug 26, 2024
View reviewed changes
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16329_1 branch 4 times, most recently from c00f9b9 to 679a20d Compare August 29, 2024 01:26
@Nasf-Fan Nasf-Fan mentioned this pull request Aug 29, 2024
Merged
18 tasks
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16329_1 branch from 679a20d to ad50e21 Compare August 30, 2024 03:48
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14984/8/execution/node/1508/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16329_1 branch from ad50e21 to e1b57a1 Compare August 31, 2024 02:27
wangshilong
wangshilong previously approved these changes Sep 2, 2024
View reviewed changes
@Nasf-Fan
DAOS-16329 chk: maintenance mode after checking pool with dryrun
7011933 
Sometimes, after system shutdown unexpectedly, the users may expect
to check their critical data under some kind of maintenance mode.
Under such mode, no user data can be modified or moved or aggregated.
That will guarantee no further potential (DAOS logic caused) damage
can happen during the check.

For such purpose, we will enhance current DAOS CR logic with --dryrun
option to allow the pool (after check) to be opened as immutable with
disabling some mechanism that may potentially cause data modification
or movement (such as rebuild or aggregation).

Under such mode, if client wants to connect to the pool, the read-only
option must be specified. Similarly for opening container in such pool.

Test-tag: pr cat_recov
Allow-unstable-test: true

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16329_1 branch from e1b57a1 to 7011933 Compare September 5, 2024 01:51
daltonbohning
daltonbohning reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will reserve approval for those familiar with core code, I think we will need to force land for the existing NLT failure

@Nasf-Fan Nasf-Fan requested a review from a team September 13, 2024 04:56
@Nasf-Fan
Copy link
Contributor Author

Ping @daos-stack/daos-gatekeeper , thanks!

@daltonbohning
Copy link
Contributor

I'm not familiar enough to merge myself without reviews from relevant @daos-stack/metadata-owners and @daos-stack/client-api-owners. Will leave this to another gatekeeper or let those owners approve first.

@Nasf-Fan
Copy link
Contributor Author

I'm not familiar enough to merge myself without reviews from relevant @daos-stack/metadata-owners and @daos-stack/client-api-owners. Will leave this to another gatekeeper or let those owners approve first.

Ping @gnailzenh @NiuYawei @daos-stack/daos-gatekeeper , thanks!

@gnailzenh gnailzenh merged commit 7ce9923 into master Sep 25, 2024
53 of 55 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-16329_1 branch September 25, 2024 12:21
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@wangshilong wangshilong wangshilong approved these changes

@gnailzenh gnailzenh gnailzenh approved these changes

@kjacque kjacque kjacque approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nasf-Fan @daosbuild1 @daltonbohning @wangshilong @gnailzenh @kjacque