Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16381 test: Run IOR with HDF5-VOL with multiple object classes (… #14982

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

shimizukko
Copy link
Contributor

#14964)

Currently, the logic in util/file_count_test_base.py runs IOR with HDF5-VOL with only one object class. The second (and beyond) object class will not run with HDF5-VOL (it runs as a normal IOR). Update line 120 to:

if api == 'HDF5-VOL':

so that if multiple object classes are defined in the test yaml, all of them will run with HDF5-VOL.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_io_sys_admin test_largefilecount test_smallfilecount

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

…14964)

Currently, the logic in util/file_count_test_base.py runs IOR with HDF5-VOL
with only one object class. The second (and beyond) object class will not
run with HDF5-VOL (it runs as a normal IOR). Update line 120 to:

if api == 'HDF5-VOL':

so that if multiple object classes are defined in the test yaml, all of them
will run with HDF5-VOL.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_io_sys_admin test_largefilecount test_smallfilecount
Signed-off-by: Makito Kano <[email protected]>
Copy link

Ticket title is 'Run IOR with HDF5-VOL with multiple object classes'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-16381

@shimizukko shimizukko marked this pull request as ready for review August 23, 2024 05:44
@shimizukko shimizukko requested review from a team as code owners August 23, 2024 05:44
@shimizukko shimizukko added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 23, 2024
@shimizukko
Copy link
Contributor Author

  • io_sys_admin.py ended with WARN as expected.
  • Checked that both object classes (SX and EC_2P1GX) had the env vars (-genv HDF5_VOL_CONNECTOR=daos -genv HDF5_PLUGIN_PATH=/usr/lib64/mpich/lib) set to the mpirun command.

@daltonbohning daltonbohning requested a review from a team August 27, 2024 21:43
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 27, 2024
@daltonbohning daltonbohning merged commit d7c4314 into release/2.6 Aug 27, 2024
45 checks passed
@daltonbohning daltonbohning deleted the makito/DAOS-16381-2.6 branch August 27, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

3 participants