Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14416 umem: Handle scm_sz ~ meta_sz with the v2 allocator #14977

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

sherintg
Copy link
Collaborator

  • The 80% rule for NE buckets will not be applied if the scm_sz is almost equal to meta_sz.
  • Corrected the check for toggling between V1 and V2 store type when scm_sz passed is zero.
  • Added assert to catch incorrect computation of chunk_id if zone counts are not set during boot correctly.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

- The 80% rule for NE buckets will not be applied if the scm_sz is
  almost equal to meta_sz.
- Corrected the check for toggling between V1 and V2 store type
  when scm_sz passed  is zero.
- Added assert to catch incorrect computation of chunk_id if zone
  counts are not set during boot correctly.

Signed-off-by: Sherin T George <[email protected]>
Copy link

Ticket title is 'Pass meta_sz through vos_pool_create call-stack'
Status is 'Resolved'
Labels: 'md_on_ssd2'
Errors are Unknown component
https://daosio.atlassian.net/browse/DAOS-14416

Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@tanabarr
Copy link
Contributor

It looks likely that the GH/Jira workflow may be confused because "umem" isn't recognised as a component name in the commit title. I'm not sure which recognised component name would be suitable.

@sherintg sherintg marked this pull request as ready for review August 22, 2024 05:08
@sherintg sherintg requested review from a team as code owners August 22, 2024 05:08
@NiuYawei NiuYawei merged commit 4fb7d87 into feature/vos_on_blob_p2 Aug 22, 2024
43 of 47 checks passed
@NiuYawei NiuYawei deleted the sherintg/vos_on_blob_p2/DAOS-14416 branch August 22, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants