Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16278 vos: per pool backend type #14946

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

NiuYawei
Copy link
Contributor

Use user specified backend type when possible, if user specify BMEM V1 backend and try to create a pool with "meta_size > scm_size", turn to use BMEM V2 instead.

Store the per-pool backend type in meta blob header for pool open.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Use user specified backend type when possible, if user specify BMEM
V1 backend and try to create a pool with "meta_size > scm_size", turn
to use BMEM V2 instead.

Store the per-pool backend type in meta blob header for pool open.

Required-githooks: true

Signed-off-by: Niu Yawei <[email protected]>
@NiuYawei NiuYawei requested review from a team as code owners August 16, 2024 10:49
@NiuYawei NiuYawei requested review from tanabarr, jolivier23 and sherintg and removed request for a team August 16, 2024 10:49
Copy link

github-actions bot commented Aug 16, 2024

Ticket title is 'Work out which MD_ON_SSD (DAV allocator) mode to use at runtime'
Status is 'In Review'
Labels: 'md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-16278

@NiuYawei NiuYawei requested a review from wangshilong August 16, 2024 10:50
@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14946/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14946/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14946/1/execution/node/1488/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14946/1/execution/node/1520/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14946/1/execution/node/1504/log

Don't init pool backend as BMEM if md-on-ssd isn't configured.

Required-githooks: true

Signed-off-by: Niu Yawei <[email protected]>
@NiuYawei NiuYawei merged commit 0ba3bcf into feature/vos_on_blob_p2 Aug 20, 2024
50 of 53 checks passed
@NiuYawei NiuYawei deleted the niu/vos_on_blob_p2/DAOS-16278 branch August 20, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants