Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15960 tests: Improvements for io_sys_admin test (#14503) #14903

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

saurabhtandan
Copy link
Contributor

Use different set of oclasses for ior and mdtest.
Add intercept option in mdtest_test_base.
Use interception for POSIX runs in the test.

Test-tag: pr test_io_sys_admin test_largefilecount test_smallfilecount test_basic_checkout_dm

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Use different set of oclasses for ior and mdtest.
Add intercept option in mdtest_test_base.
Use interception for POSIX runs in the test.

Test-tag: pr test_io_sys_admin test_largefilecount test_smallfilecount test_basic_checkout_dm

Signed-off-by: Saurabh Tandan <[email protected]>
Copy link

github-actions bot commented Aug 8, 2024

Ticket title is 'io_sys_admin improvements'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.1,scrubbed_2.8,tds'
https://daosio.atlassian.net/browse/DAOS-15960

@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 8, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14903/2/display/redirect

Test-tag: pr test_io_sys_admin test_largefilecount test_smallfilecount test_basic_checkout_dm

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning marked this pull request as ready for review August 12, 2024 15:49
@daltonbohning daltonbohning requested review from a team as code owners August 12, 2024 15:49
@daltonbohning daltonbohning merged commit 2cd3dc3 into release/2.6 Aug 12, 2024
53 checks passed
@daltonbohning daltonbohning deleted the standan/DAOS-15960_2.6 branch August 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits
Development

Successfully merging this pull request may close these issues.

4 participants