-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-15961 cart: Reorganize how envs are handled (#14504) #14887
Conversation
Change to how cart deals with envariables: - env list is now controlled by CRT_ENV_LIST macro in crt_types_internal.h - all envs stored in structure generated from CRT_ENV_LST (crrt_genv) now, ENV is read out at crt_env_init() time and env strings deallocated at crt_env_fini(). - accsor functions/macros crt_env_init/fini/get/dump are provided. - string-type envs no longer need to be freed after retrieval. - Change cart utility function to populate crt_init_options_t instead of setting and querying env. With this change, any env to be used will need to appear on the list first, ensuring it gets dumped as well as ensuring proper name usage later. Env name typos when using crt_env_get() will now result in compile time errors Required-githooks: true Signed-off-by: Alexander A Oganezov <[email protected]>
Ticket title is 'Reorganize how cart handles envariables' |
Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/1/execution/node/358/log |
- fix bad crt_env_get() macro that incorrectly expanded in single line statements Signed-off-by: Alexander A Oganezov <[email protected]>
Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/2/execution/node/386/log |
Required-githooks: true Signed-off-by: Alexander A Oganezov <[email protected]>
Required-githooks: true Signed-off-by: Alexander A Oganezov <[email protected]>
Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/4/execution/node/1209/log |
Required-githooks: true Signed-off-by: Alexander A Oganezov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ftest LGTM
Required-githooks: true Signed-off-by: Alexander A Oganezov <[email protected]>
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/7/execution/node/1447/log |
|
Cherry-pick of 2 PRs from master:
993558e - env reorg
7f80548 - bugfix to env reorg
Change to how cart deals with envariables:
With this change, any env to be used will need to appear on the list first, ensuring it gets dumped as well as ensuring proper name usage later. Env name typos when using crt_env_get() will now result in compile time errors
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: