Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15961 cart: Reorganize how envs are handled (#14504) #14887

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

frostedcmos
Copy link
Contributor

@frostedcmos frostedcmos commented Aug 6, 2024

Cherry-pick of 2 PRs from master:
993558e - env reorg
7f80548 - bugfix to env reorg

Change to how cart deals with envariables:

  • env list is now controlled by CRT_ENV_LIST macro in crt_types_internal.h
  • all envs stored in structure generated from CRT_ENV_LST (crrt_genv) now, ENV is read out at crt_env_init() time and env strings deallocated at crt_env_fini().
  • accsor functions/macros crt_env_init/fini/get/dump are provided.
  • string-type envs no longer need to be freed after retrieval.
  • Change cart utility function to populate crt_init_options_t instead of setting and querying env.

With this change, any env to be used will need to appear on the list first, ensuring it gets dumped as well as ensuring proper name usage later. Env name typos when using crt_env_get() will now result in compile time errors

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Change to how cart deals with envariables:
- env list is now controlled by CRT_ENV_LIST macro in crt_types_internal.h
- all envs stored in structure generated from CRT_ENV_LST (crrt_genv) now,
  ENV is read out at crt_env_init() time and env strings deallocated at crt_env_fini().
- accsor functions/macros crt_env_init/fini/get/dump are provided.
- string-type envs no longer need to be freed after retrieval.
- Change cart utility function to populate crt_init_options_t instead of setting and querying env.

With this change, any env to be used will need to appear on the list first, ensuring it gets
dumped as well as ensuring proper name usage later. Env name typos when using crt_env_get()
will now result in compile time errors

Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
Copy link

github-actions bot commented Aug 6, 2024

Ticket title is 'Reorganize how cart handles envariables'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-15961

@frostedcmos frostedcmos marked this pull request as ready for review August 6, 2024 23:22
@frostedcmos frostedcmos requested review from a team as code owners August 6, 2024 23:22
@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/1/execution/node/358/log

- fix bad crt_env_get() macro that incorrectly expanded in single line statements

Signed-off-by: Alexander A Oganezov <[email protected]>
@frostedcmos frostedcmos added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Aug 6, 2024
@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/2/execution/node/386/log

Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
soumagne
soumagne previously approved these changes Aug 7, 2024
Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/4/execution/node/1209/log

@frostedcmos frostedcmos requested review from a team as code owners August 7, 2024 17:47
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Aug 7, 2024
@frostedcmos frostedcmos requested a review from jolivier23 August 7, 2024 22:21
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14887/7/execution/node/1447/log

@frostedcmos frostedcmos added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 8, 2024
@frostedcmos frostedcmos requested a review from a team August 8, 2024 21:59
@daltonbohning daltonbohning merged commit 9bbab7f into release/2.6 Aug 8, 2024
50 of 52 checks passed
@daltonbohning daltonbohning deleted the aaoganez/DAOS-15961-2.6-new branch August 8, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Development

Successfully merging this pull request may close these issues.

5 participants