Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16305 build: Simplify hermetic builds #14874

Merged
merged 3 commits into from
Aug 7, 2024
Merged

DAOS-16305 build: Simplify hermetic builds #14874

merged 3 commits into from
Aug 7, 2024

Conversation

jolivier23
Copy link
Contributor

Move URLs for repos to the config file allowing
one to replace the config file.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Move URLs for repos to the config file allowing
one to replace the config file.

Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 requested review from a team as code owners August 5, 2024 18:41
@jolivier23 jolivier23 requested a review from techbasset August 5, 2024 18:41
Copy link

github-actions bot commented Aug 5, 2024

Ticket title is 'Add support for hermetic build'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-16305

@jolivier23 jolivier23 requested a review from soumagne August 5, 2024 18:42
soumagne
soumagne previously approved these changes Aug 5, 2024
mjmac
mjmac previously approved these changes Aug 6, 2024
chowes
chowes previously approved these changes Aug 6, 2024
Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 dismissed stale reviews from chowes, mjmac, and soumagne via 074403b August 6, 2024 22:38
Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 requested review from mjmac, soumagne and chowes August 6, 2024 22:40
@mjmac mjmac merged commit 40d51a8 into master Aug 7, 2024
55 checks passed
@mjmac mjmac deleted the jvolivie/hermetic branch August 7, 2024 19:52
jolivier23 added a commit that referenced this pull request Aug 8, 2024
Move URLs for repos to the config file allowing
one to replace the config file.

Signed-off-by: Jeff Olivier <[email protected]>
daltonbohning pushed a commit that referenced this pull request Aug 12, 2024
Move URLs for repos to the config file allowing
one to replace the config file.

Signed-off-by: Jeff Olivier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants