Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16217 test: Update run_local(). (#14748) #14866

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

daltonbohning
Copy link
Contributor

@daltonbohning daltonbohning commented Aug 2, 2024

Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Aug 2, 2024
@daltonbohning daltonbohning added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Ticket title is 'ftest: Update run_local() to return same object type as run_remote()'
Status is 'Awaiting backport'
Labels: 'daos_framework'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16217

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Aug 2, 2024
daltonbohning pushed a commit that referenced this pull request Aug 2, 2024
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14866/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14866/1/execution/node/1090/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-16217-2.6 branch from 5726938 to 7bcdf83 Compare August 5, 2024 15:58
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14866/2/testReport/

daltonbohning pushed a commit that referenced this pull request Aug 7, 2024
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14848
Use subprocess.run instead of run_local so test output is printed while
running.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning force-pushed the dbohning/daos-16217-2.6 branch from 7bcdf83 to d8f83f1 Compare August 8, 2024 18:00
daltonbohning pushed a commit that referenced this pull request Aug 8, 2024
Update the current run_local() command to return an object similar to
run_remote() to allow them to be used interchangeably.

increase verify_perms.py timeout.

Also include #14882
Use subprocess.run() for run_local()

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14866/3/execution/node/823/log

Copy link
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor merge conflict miss.

src/tests/ftest/util/launch_utils.py Outdated Show resolved Hide resolved
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr HarnessUnitTest HarnessCoreFilesTest SoakSmoke DfuseMUPerms test_always_fails
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14866/4/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14866/4/execution/node/1149/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14866/4/execution/node/1133/log

@daltonbohning daltonbohning marked this pull request as ready for review August 12, 2024 15:40
@daltonbohning daltonbohning requested review from a team as code owners August 12, 2024 15:40
@daltonbohning
Copy link
Contributor Author

Failures in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14866/4/tests

@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 12, 2024
@daltonbohning daltonbohning requested a review from a team August 12, 2024 15:45
@phender phender merged commit f390961 into release/2.6 Aug 12, 2024
43 of 47 checks passed
@phender phender deleted the dbohning/daos-16217-2.6 branch August 12, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Development

Successfully merging this pull request may close these issues.

3 participants