Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16291 bio: auto detect faulty for an unplugged device #14850

Merged
merged 1 commit into from
Aug 15, 2024
Merged

DAOS-16291 bio: auto detect faulty for an unplugged device #14850

merged 1 commit into from
Aug 15, 2024

Conversation

NiuYawei
Copy link
Contributor

When a health device is unplugged, we should keep counting the I/O errors against the device, once the number of I/O errors reached faulty criteria, the unplugged device should be automatically marked as FAULTY and trigger targets exclusion accordingly.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@NiuYawei NiuYawei requested review from a team as code owners July 31, 2024 06:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Ticket title is 'DAOS engine doesn't handle hot-removal of healthy NVMe disk'
Status is 'In Review'
Labels: 'lrz'
https://daosio.atlassian.net/browse/DAOS-16291

tanabarr
tanabarr previously approved these changes Jul 31, 2024
View reviewed changes
wangshilong
wangshilong previously approved these changes Aug 1, 2024
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14850/1/execution/node/1543/log

liuxuezhao
liuxuezhao previously approved these changes Aug 1, 2024
View reviewed changes
@NiuYawei
DAOS-16291 bio: auto detect faulty for an unplugged device
3b04848 
When a health device is unplugged, we should keep counting the I/O errors
against the device, once the number of I/O errors reached faulty criteria,
the unplugged device should be automatically marked as FAULTY and trigger
targets exclusion accordingly.

Required-githooks: true

Signed-off-by: Niu Yawei <[email protected]>
@NiuYawei NiuYawei dismissed stale reviews from liuxuezhao, wangshilong, and tanabarr via 3b04848 August 12, 2024 08:59
@NiuYawei NiuYawei merged commit 6f50acf into master Aug 15, 2024
54 of 55 checks passed
@NiuYawei NiuYawei deleted the niu/DAOS-16291 branch August 15, 2024 13:47
NiuYawei added a commit that referenced this pull request Aug 15, 2024
@NiuYawei
DAOS-16291 bio: auto detect faulty for an unplugged device (#14850)
634a2b6 
When a health device is unplugged, we should keep counting the I/O errors
against the device, once the number of I/O errors reached faulty criteria,
the unplugged device should be automatically marked as FAULTY and trigger
targets exclusion accordingly.

Signed-off-by: Niu Yawei <[email protected]>
gnailzenh pushed a commit that referenced this pull request Aug 20, 2024
@NiuYawei
DAOS-16291 bio: auto detect faulty for an unplugged device (#14850) (#…
13307e2 
…14936)

When a health device is unplugged, we should keep counting the I/O errors
against the device, once the number of I/O errors reached faulty criteria,
the unplugged device should be automatically marked as FAULTY and trigger
targets exclusion accordingly.

Signed-off-by: Niu Yawei <[email protected]>
@juszhan1 juszhan1 mentioned this pull request Aug 26, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangshilong wangshilong wangshilong approved these changes

@tanabarr tanabarr tanabarr approved these changes

@liuxuezhao liuxuezhao liuxuezhao approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NiuYawei @daosbuild1 @liuxuezhao @tanabarr @wangshilong