Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-recv buffers #14683

Merged
merged 1 commit into from
Aug 13, 2024
Merged

DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-recv buffers #14683

merged 1 commit into from
Aug 13, 2024

Conversation

soumagne
Copy link
Collaborator

@soumagne soumagne commented Jul 2, 2024

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Ticket title is 'Aurora ECB testing: 256ECB:105 servers - ior with MPIIO/DFS EC_16P2GX hung'
Status is 'In Progress'
Labels: 'daos_ecb_issue,daos_ecb_scale,request_for_2.6.1,scrubbed_2.8,triaged'
https://daosio.atlassian.net/browse/DAOS-15914

daltonbohning added a commit that referenced this pull request Jul 3, 2024
@daltonbohning
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r…
03eb549 
…ecv buffers #14683

Signed-off-by: Jerome Soumagne <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14683/1/execution/node/1505/log

daltonbohning added a commit that referenced this pull request Jul 8, 2024
@daltonbohning
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r…
4d9d963 
…ecv buffers #14683

Signed-off-by: Jerome Soumagne <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14683/2/execution/node/381/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14683/2/execution/node/314/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14683/2/execution/node/434/log

daltonbohning added a commit that referenced this pull request Jul 12, 2024
@daltonbohning
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r…
044183e 
…ecv buffers #14683

Signed-off-by: Jerome Soumagne <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jul 18, 2024
@daltonbohning
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r…
0b33238 
…ecv buffers #14683

Signed-off-by: Jerome Soumagne <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jul 18, 2024
@daltonbohning
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r…
a2c6a46 
…ecv buffers #14683

Signed-off-by: Jerome Soumagne <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jul 18, 2024
@daltonbohning
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r…
0cf62cc 
…ecv buffers #14683

Signed-off-by: Jerome Soumagne <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@soumagne soumagne force-pushed the soumagne/mrecv_buf_26 branch from bb0ef9b to 961cc81 Compare August 7, 2024 16:47
@soumagne
DAOS-15914 cart: add D_MRECV_BUF env var to control number of multi-r… (
0b53e80 
#14662)

Default to 16 multi-recv buffers instead of 4

Switch to using HG_Init_opt2() to select init info version

Add also D_MRECV_BUF_COPY to control copy threshold of multi-recv buffers
(default is disabled)

Signed-off-by: Jerome Soumagne <[email protected]>
@soumagne soumagne force-pushed the soumagne/mrecv_buf_26 branch from 961cc81 to 0b53e80 Compare August 12, 2024 19:47
@soumagne soumagne marked this pull request as ready for review August 12, 2024 19:47
@soumagne soumagne requested review from a team as code owners August 12, 2024 19:47
@soumagne soumagne requested a review from daltonbohning August 12, 2024 19:47
@soumagne soumagne added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 12, 2024
@sylviachanoiyee
Copy link
Contributor

This PR is approved for 2.6.1

@daltonbohning daltonbohning merged commit 485fced into release/2.6 Aug 13, 2024
52 checks passed
@daltonbohning daltonbohning deleted the soumagne/mrecv_buf_26 branch August 13, 2024 18:10
jolivier23 added a commit that referenced this pull request Aug 19, 2024
@jolivier23
Revert "DAOS-15914 cart: add D_MRECV_BUF env var to control number of…
4d0d372 
… multi-r… (#14662) (#14683)"

This reverts commit 485fced.
@jolivier23 jolivier23 mentioned this pull request Aug 19, 2024
Merged
jolivier23 added a commit that referenced this pull request Oct 29, 2024
@jolivier23
Reapply "DAOS-15914 cart: add D_MRECV_BUF env var to control number o…
03639cb 
…f multi-r… (#14662) (#14683)"

This reverts commit 4d0d372.
@jolivier23 jolivier23 mentioned this pull request Oct 29, 2024
Merged
jolivier23 added a commit that referenced this pull request Oct 30, 2024
@jolivier23
Reapply "DAOS-15914 cart: add D_MRECV_BUF env var to control number o…
ff63c34 
…f multi-r… (#14662) (#14683)"

This reverts commit 4d0d372.
jolivier23 added a commit that referenced this pull request Nov 1, 2024
@jolivier23
Reapply "DAOS-15914 cart: add D_MRECV_BUF env var to control number o…
f6308ff 
…f multi-r… (#14662) (#14683)"

This reverts commit 4d0d372.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumagne @daosbuild1 @sylviachanoiyee @daltonbohning