Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15992 client: set st_blksize in ostatx_cb() and add unit test #14666

Merged
merged 3 commits into from
Aug 21, 2024
Merged

DAOS-15992 client: set st_blksize in ostatx_cb() and add unit test #14666

merged 3 commits into from
Aug 21, 2024

Conversation

wiliamhuang
Copy link
Contributor

Python buffered read/write relies on st_blksize as default buffer size. dfuse calls dfs_ostatx() which returns stat with zero st_blksize. Consequently, 4096 for st_blksize is returned to application.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wiliamhuang
DAOS-15992 client: set st_blksize in ostatx_cb() and add unit test (#…
d8b2022 
…14534)

Python buffered read/write relies on st_blksize as default buffer size. dfuse calls dfs_ostatx() which returns stat with zero st_blksize. Consequently, 4096 for st_blksize is returned to application.

Signed-off-by: Lei Huang <[email protected]>
@github-actions GitHub Actions
Copy link

Ticket title is 'st_blksize in stat is not set inside ostatx_cb'
Status is 'Awaiting backport'
Labels: 'scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-15992

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jun 28, 2024
@wiliamhuang wiliamhuang added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 28, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14666/2/execution/node/1563/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14666/2/execution/node/1709/log

@wiliamhuang
Copy link
Contributor Author

The failures in hardware tests in CI are not related to this PR. Existing tickets,
https://daosio.atlassian.net/browse/DAOS-15608
https://daosio.atlassian.net/browse/DAOS-16168
https://daosio.atlassian.net/browse/DAOS-15243

@wiliamhuang wiliamhuang marked this pull request as ready for review July 8, 2024 15:42
@wiliamhuang wiliamhuang requested review from a team as code owners July 8, 2024 15:42
@wiliamhuang wiliamhuang requested a review from daltonbohning July 8, 2024 15:43
@daltonbohning daltonbohning added the release-2.6.1 Targeted for release 2.6.1 label Jul 8, 2024
@mchaarawi
Copy link
Contributor

could you please rebase with latest 2.6 and push again? thanks

@wiliamhuang
Merge branch 'release/2.6' into lei/DAOS-15992_2.6
ad22b84 
Required-githooks: true

Signed-off-by: Lei Huang <[email protected]>
@wiliamhuang
Copy link
Contributor Author

could you please rebase with latest 2.6 and push again? thanks

Thank you! I just merged this PR with release/2.6.

@wiliamhuang
Merge branch 'release/2.6' into lei/DAOS-15992_2.6
bdd8bbc 
Allow-unstable-test: true
Features: pil4dfs

Signed-off-by: Lei Huang <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14666/4/execution/node/1508/log

@wiliamhuang
Copy link
Contributor Author

The only failure is an existing issue.
https://daosio.atlassian.net/browse/DAOS-16315
dfuse/pil4dfs_fio.py:Pil4dfsFio.test_pil4dfs_vs_dfs - test timeout running fio

@wiliamhuang wiliamhuang requested a review from a team August 20, 2024 23:28
@wiliamhuang wiliamhuang added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 20, 2024
@mchaarawi mchaarawi merged commit b917563 into release/2.6 Aug 21, 2024
49 of 52 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-15992_2.6 branch August 21, 2024 13:02
@juszhan1 juszhan1 mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@mchaarawi mchaarawi mchaarawi approved these changes

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.6.1 Targeted for release 2.6.1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wiliamhuang @daosbuild1 @mchaarawi @daltonbohning