Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16001 placement: fix cases for delay_rebuild #14557

Merged
merged 1 commit into from
Jun 21, 2024
Merged

DAOS-16001 placement: fix cases for delay_rebuild #14557

merged 1 commit into from
Jun 21, 2024

Conversation

liuxuezhao
Copy link
Contributor

Features: rebuild
Allow-unstable-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

Ticket title is 'data mismatch found for delay_rebuild mode in exclude+reintegrate test'
Status is 'In Progress'
Labels: 'google-cloud-daos,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16001

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14557/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14557/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14557/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14557/4/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14557/4/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14557/5/execution/node/1183/log

@liuxuezhao
DAOS-16001 placement: fix cases for delay_rebuild
d03f421 
Features: rebuild
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
@liuxuezhao liuxuezhao mentioned this pull request Jun 14, 2024
Merged
18 tasks
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14557/6/execution/node/1552/log

@liuxuezhao liuxuezhao marked this pull request as ready for review June 18, 2024 09:15
@liuxuezhao liuxuezhao requested review from a team as code owners June 18, 2024 09:15
@liuxuezhao
Copy link
Contributor Author

test_daos_rebuild_simple the test failure is known issue https://daosio.atlassian.net/browse/DAOS-15290

@liuxuezhao liuxuezhao requested a review from wangshilong June 18, 2024 09:16
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14557/6/execution/node/1506/log

@liuxuezhao liuxuezhao requested a review from jolivier23 June 19, 2024 07:48
@liuxuezhao liuxuezhao requested a review from gnailzenh June 20, 2024 08:10
daltonbohning
daltonbohning reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest code LGTM, but is the deployment/target_failure.py:TargetFailure.test_target_failure_with_rp failure expected? I can't find an existing ticket

@liuxuezhao
Copy link
Contributor Author

ftest code LGTM, but is the deployment/target_failure.py:TargetFailure.test_target_failure_with_rp failure expected? I can't find an existing ticket

that test's rebuild did not complete in time, I think should be unrelated with this PR, I created https://daosio.atlassian.net/browse/DAOS-16086 for it.

@liuxuezhao liuxuezhao added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 20, 2024
@liuxuezhao
Copy link
Contributor Author

that test's rebuild did not complete in time, I think should be unrelated with this PR, I created https://daosio.atlassian.net/browse/DAOS-16086 for it.

this failure also observed without this PR, see the ticket.

@gnailzenh gnailzenh merged commit 2d1a372 into master Jun 21, 2024
48 of 52 checks passed
@gnailzenh gnailzenh deleted the lxz/rb_layout branch June 21, 2024 05:53
jolivier23 pushed a commit that referenced this pull request Jun 21, 2024
@liuxuezhao @jolivier23
DAOS-16001 placement: fix cases for delay_rebuild (#14557)
7d60c74 
Placement fixes for delayed rebuild

* Note: this is just a partial backport of stuff that changed since
we backported it (See #14558) before it landed on master branch.

Signed-off-by: Xuezhao Liu <[email protected]>
jolivier23 added a commit that referenced this pull request Jun 24, 2024
@jolivier23
DAOS-16001 placement: fix cases for delay_rebuild (#14557) (#14626)
0fdd529 
Placement fixes for delayed rebuild

* Note: this is just a partial backport of tests that changed since
we backported it (See #14558) before it landed on master branch.

Signed-off-by: Xuezhao Liu <[email protected]>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@gnailzenh gnailzenh gnailzenh approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@wangshilong wangshilong wangshilong approved these changes

@Nasf-Fan Nasf-Fan Awaiting requested review from Nasf-Fan

@kccain kccain Awaiting requested review from kccain

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liuxuezhao @daosbuild1 @wangshilong @NiuYawei @gnailzenh @daltonbohning