Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aurora/2.6 test branch #14539

Draft
wants to merge 12 commits into
base: release/2.6
Choose a base branch
from
Draft

aurora/2.6 test branch #14539

wants to merge 12 commits into from

Conversation

daltonbohning
Copy link
Contributor

2.6 test branch for Aurora

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning added don't land do-not-delete-branch Branch is required for CI testing labels Jun 10, 2024
@daltonbohning daltonbohning self-assigned this Jun 10, 2024
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/aurora/2.6

@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 3 times, most recently from 54e974f to da88cb8 Compare June 20, 2024 14:43
@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 2 times, most recently from 9160091 to 99b7a5a Compare July 8, 2024 20:59
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/387/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/384/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/380/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/379/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/8/execution/node/318/log

@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 4 times, most recently from fa6571a to 20cf312 Compare July 18, 2024 19:10
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/12/execution/node/824/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/13/execution/node/823/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/14/execution/node/804/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/15/execution/node/798/log

daltonbohning
daltonbohning commented Jul 25, 2024
View reviewed changes
src/tests/ftest/harness/coverage.py Outdated
@@ -6,6 +6,7 @@

from apricot import TestWithServers
from dfuse_utils import get_dfuse, start_dfuse
from general_utils import get_journalctl, journalctl_time, get_journalctl_command
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove

saurabhtandan
saurabhtandan reviewed Jul 30, 2024
View reviewed changes
src/tests/ftest/util/general_utils.py Outdated
@@ -923,7 +928,7 @@ def create_directory(hosts, directory, timeout=15, verbose=True,

"""
mkdir_command = "/usr/bin/mkdir -p {}".format(directory)
command = get_clush_command(hosts, args="-S -v", command=mkdir_command, command_sudo=sudo)
command = get_clush_command(hosts, args="-S -B -v", command=mkdir_command, command_sudo=sudo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While scaling for 2KECBs I encountered an issue while agent startup when it was unable to create dirs to be able to copy on all ECB in time. I tried increasing the timeout and that did not help either. But adding fanout to clush command helped instead.

Suggested change
command = get_clush_command(hosts, args="-S -B -v", command=mkdir_command, command_sudo=sudo)
command = get_clush_command(hosts, args="-S -B -v -f 1024", command=mkdir_command, command_sudo=sudo)

Or something like that.
Let me know what you think of adding this here in the build.
IMO if there is a way to add some higher fanout values at a single place to all clush commands in our infrastructure for Aurora, it will he helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really these direct clush commands should be replaced with run_remote, then run_remote can increase the fanout for all clush commands.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14539/20/execution/node/145/log

@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 7 times, most recently from f7b0319 to c27ea4d Compare October 29, 2024 18:12
@daltonbohning daltonbohning force-pushed the aurora/2.6 branch 10 times, most recently from 4d8cb8b to 2f1d59f Compare November 4, 2024 20:34
daltonbohning and others added 11 commits November 4, 2024 20:50
@daltonbohning
wip: more support for sudo-less client
99ce127 
Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
export daos-related envs in run_remote and clush
299bbda 
Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
update agent_failure to run journalctl as user
f278dfe 
Skip-test: true
Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
disable some unused / not working teardown steps
5ccd81b 
Skip-test: true
Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
optimize move_files when archiving to /lus on computes
5364623 
Skip-test: true
Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@rpadma2 @daltonbohning
DAOS-16592 test: Agent failure test changes.
59dc4d0 
Skip-build: true

Summary: Agent failure test changes to support ECBs.

Required-githooks: true

Signed-off-by: Padmanabhan <[email protected]>
@mjean308 @daltonbohning
DAOS-16167 test: 10102024 update soak to use internal job scheduler
fcfaec8 
Skip-build: true

Required-githooks: true

Signed-off-by: Maureen Jean <[email protected]>
@mjean308 @daltonbohning
include correct soak updates for 2.6
3d1dac8 
Required-githooks: true

Signed-off-by: Maureen Jean <[email protected]>
@soumagne @daltonbohning
DAOS-16752 build: update mercury to 2.4.0
ad1996a 
PR-repos: libfabric@PR-77:lastBuild mercury@PR-122:lastBuild
Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
@daltonbohning
test: hardcode come envs
6cb76b3 
SKip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@mjean308 @daltonbohning
Update vmd harasser with 2.6 function (#15440)
d7eb3dd 
Skip-build: true

Required-githooks: true

Signed-off-by: Maureen Jean <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@Nasf-Fan @daltonbohning
DAOS-16721 dtx: handle potential DTX ID reusing trouble - b26
e8536cc 
Skip-build: true

The patch contains the following improvements:

1. When VOS level logic returns -DER_TX_RESATRT, the object level RPC
   handler should set 'RESEND' flag then restart the transaction with
   newer epoch. Because dtx_abort() logic cannot guarantee all former
   prepared DTX entries (on all related participants) can be aborted,
   especially if the former one failed for some network trouble, that
   may cause restarted transaction hit -DER_TX_ID_REUSED unexpectedly.

2. Compare the epoch for DTX entries with the same transaction ID for
   distinguishing potential reused TX ID more accurately.

3. Add DTX entry into DTX CoS cache if cannot commit it synchronously.
   Then subsequent batched commit logic can handle it.

4. If server complains suspected TX ID reusing, then reports -EIO to
   related application instead of assertion on client.

5. Control DTX related warning message frequency to avoid log flood.

6. Collect more information when generate some error/warning message.

Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Fan Yong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhtandan saurabhtandan saurabhtandan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@daltonbohning daltonbohning

Labels
do-not-delete-branch Branch is required for CI testing don't land
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@daltonbohning @daosbuild1 @saurabhtandan @rpadma2 @mjean308 @soumagne @Nasf-Fan