Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15852 test: more timing samples for co_op_dup_timing() #14497

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jun 3, 2024

Rarely, this test will produce timings that exceed the failure threshold. Local and PR/CI experiments have shown that increasing the test's NUM_OPS to more than 200 iterations greatly reduces or may eliminate such intermittent timing failures, by "spreading out" the magnitude of the time spent in the 3 main loops of the test (0% loops perform fault injections, 33%, and 50%).

Test-tag: test_daos_container
Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Rarely, this test will produce timings that exceed the failure
threshold. Local and PR/CI experiments have shown that increasing
the test's NUM_OPS to more than 200 iterations greatly reduces
or may eliminate such intermittent timing failures, by "spreading out"
the magnitude of the time spent in the 3 main loops of the test
(0% loops perform fault injections, 33%, and 50%).

Test-tag: test_daos_container
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Kenneth Cain <[email protected]>
Copy link

github-actions bot commented Jun 3, 2024

Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_container - DAOS_Container.CONT35 num_failures == 0'
Status is 'In Progress'
Labels: 'ci_impact,md_on_ssd,pr_test,triaged'
https://daosio.atlassian.net/browse/DAOS-15852

@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 3, 2024
@kccain kccain marked this pull request as ready for review June 4, 2024 20:41
@kccain kccain requested review from liw and wangshilong June 4, 2024 20:42
Copy link
Contributor

@liw liw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be okay with regard to the test session timeout, I assume?

@kccain
Copy link
Contributor Author

kccain commented Jun 5, 2024

We will be okay with regard to the test session timeout, I assume?

I think so. This change may add ~10-15 seconds of runtime. The CI test run showed about 100 seconds of time left at the time the ftest invoked teardown.

@kccain kccain requested review from wangshilong and removed request for wangshilong June 11, 2024 16:04
@kccain kccain requested a review from a team June 12, 2024 02:25
@daltonbohning daltonbohning merged commit 6c14a9b into master Jun 12, 2024
43 checks passed
@daltonbohning daltonbohning deleted the kccain/daos_15852_land branch June 12, 2024 13:56
kccain added a commit that referenced this pull request Oct 15, 2024
Rarely, this test will produce timings that exceed the failure
threshold. Local and PR/CI experiments have shown that increasing
the test's NUM_OPS to more than 200 iterations greatly reduces
or may eliminate such intermittent timing failures, by "spreading out"
the magnitude of the time spent in the 3 main loops of the test
(0% loops perform fault injections, 33%, and 50%).

Test-tag: test_daos_container
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Kenneth Cain <[email protected]>
gnailzenh pushed a commit that referenced this pull request Oct 19, 2024
…15324)

Rarely, this test will produce timings that exceed the failure
threshold. Local and PR/CI experiments have shown that increasing
the test's NUM_OPS to more than 200 iterations greatly reduces
or may eliminate such intermittent timing failures, by "spreading out"
the magnitude of the time spent in the 3 main loops of the test
(0% loops perform fault injections, 33%, and 50%).


Signed-off-by: Kenneth Cain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants