Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-15937 test: Automate metadata duplicate rpc detection time consuming #14473
base: master
Are you sure you want to change the base?
DAOS-15937 test: Automate metadata duplicate rpc detection time consuming #14473
Changes from 88 commits
238e8e4
95100ab
9a67543
09ff0cb
129205b
a98bce9
9f02561
8ed567c
02a265a
d5e7422
297eae5
b8e750a
bd3f199
5d067a9
195afed
477ceee
f09de12
f53b72f
4f8efdd
bf0102e
f560bbd
bf956d2
de22b28
d332009
e97e68c
a48eae2
e849863
61a6a4f
28babe2
aadba94
c71fe72
1d01888
e320a22
350276f
f70788c
c582b41
9b3eb4e
adf7ef7
426b046
7fcdd1e
d38fd75
c2a2276
38ce1eb
56a5af1
32479ea
2e4f13d
701b48a
091faef
ae6008f
4d21e0b
11c14ea
cddc526
70ea60d
2db908d
b9194d3
ba9e54d
966f5c7
c42229e
8c2046e
7ac504f
7c57f3f
4ac3116
8e2a751
1a052ff
2d2a1a4
b1c7728
682dfa6
51f0ef2
5e08dc4
7e2124f
23b096f
536001d
95939ab
c5b8717
a8ea862
5e0c8db
1e646ef
d56e5b1
8250041
8ec32ff
0928f3a
e118912
384efe0
7bb1dea
6d40d39
519d4c0
8ab5f43
0649717
f0e9314
4efb7a9
50444a1
542bca9
834d90a
0f7ae5b
ae16475
8d4602c
76eb46f
984aefc
2b8dd5d
62ad7aa
595fcaa
a0a7468
735a5fc
fa3564b
223c922
28525a1
4b89f5a
fcd1952
5490200
e428682
f6addc1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test steps documentation for step 4 should not specify that it is calculating an average for those loops following svc_ops_entry_age time.
This verification seems OK, since we expect the "early" loops before svc_ops_entry_age to be quicker than what the performance will "stabilize" to after svc_ops_entry_age time. i.e., all timings before and after svc_ops_entry_age time should fit underneath the baseline times the threshold_factor. But we particularly care about the iterations after svc_ops_entry_age time has passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the new commit, which should have addressed all the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to have log_mask: ERR when running a performance-sensitive test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the new commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to have log_mask: ERR when running a performance-sensitive test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the new commit.