Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport two changes that can improve rebuild stability #14452

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

jolivier23
Copy link
Contributor

@jolivier23 jolivier23 commented May 28, 2024

DAOS-14010 vos: Allow rebuild overwrite (#13326)
DAOS-15670 vos: SV overwrite missed tx_add_range() (#14241)

  • Partial overwrite is difficult for upper layer to avoid. If we reserve a range of minor epochs for rebuild, we can just always allow rebuild to overwrite any extents currently in the tree for the given major epoch.

  • In SV overwrite case, the btr_update_record() will defer free the original record and allocate new record for record replacing, however, btr_node_tx_add() is mistakenly skipped in btr_update(), that leads to:

  1. In md-on-ssd mode, tree node changes are missed in WAL.
  2. In pmem mode, tree node snapshot is missed in undo log.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

DAOS-14010 vos: Allow rebuild overwrite (#13326)
DAOS-15670 vos: SV overwrite missed tx_add_range() (#14241)

* Partial overwrite is difficult for upper layer to avoid.  If we
reserve a range of minor epochs for rebuild, we can just always allow
rebuild to overwrite what any extents currently in the tree for the
given major epoch.

* In SV overwerite case, the btr_update_record() will defer free
the original record and allocate new record for record replacing,
however, btr_node_tx_add() is mistakenly skipped in btr_update(),
that leads to:
1. In md-on-ssd mode, tree node changes are missed in WAL.
2. In pmem mode, tree node snapshot is missed in undo log.

Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Niu Yawei <[email protected]>
Copy link

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Backport

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14452/1/execution/node/413/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14452/1/execution/node/395/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14452/1/execution/node/398/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14452/1/execution/node/375/log

@daosbuild1
Copy link
Collaborator

Required-githooks: true

Change-Id: Id41f790cb44723ef65955a6513bc3dddb7057ad2
Signed-off-by: Jeff Olivier <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Change-Id: I1fcd9e8d65569afc6ff7b312ac7677ddb35b914b
Required-githooks: true

Change-Id: Ib1aad1e9f2ba2f06bfb05c3dd5ca17875bf8b2d9
Signed-off-by: Jeff Olivier <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 requested a review from johannlombardi May 29, 2024 19:28
@jolivier23 jolivier23 changed the title Backport two changes that can improve stability Backport two changes that can improve rebuild stability May 30, 2024
@jolivier23 jolivier23 requested review from techbasset and mjmac May 30, 2024 03:09
@jolivier23 jolivier23 merged commit 856daa0 into google/2.4 Jun 5, 2024
36 checks passed
@jolivier23 jolivier23 deleted the jvolivie/try_backport branch June 5, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants