b/340244046 initial port collect command from master to 2.4 #14409

cdavis28 · 2024-05-20T18:36:27Z

Manual cherry-pick of code from master for the "collect-log" command.

jolivier23 · 2024-05-20T18:38:51Z

Could you add a list of backport titles to the description

e.g. backports the following PRs

DAOS-XYZ blah: ..... (# PR number)

That would help understanding the patch

daosbuild1 · 2024-05-20T18:43:27Z

src/control/lib/support/README.md

+for debugging purpose.This options is available for `daos_server`, `dmg` and `daos_agent` binaries. 
+It will collect the specific logs, config and other DAOS related metrics and system information.
+
+`dmg support collect-log` is the single command, which will initiate the log collection 


Suggested change

for debugging purpose.This options is available for `daos_server`, `dmg` and `daos_agent` binaries.

It will collect the specific logs, config and other DAOS related metrics and system information.

`dmg support collect-log` is the single command, which will initiate the log collection

for debugging purpose.This options is available for `daos_server`, `dmg` and `daos_agent` binaries.

It will collect the specific logs, config and other DAOS related metrics and system information.

`dmg support collect-log` is the single command, which will initiate the log collection

daosbuild1 · 2024-05-20T18:43:27Z

src/proto/Makefile

+#	go get -u $(PROTOC_GEN_GO_IMP) &&\
+#	cd $(GOPATH)/src/$(PROTOC_GEN_GO_IMP) &&\
+#	git checkout $(PROTOC_GEN_GO_TAG) &&\
+	go install $(PROTOC_GEN_GO_IMP)@$(PROTOC_GEN_GO_TAG) 


Suggested change

go install $(PROTOC_GEN_GO_IMP)@$(PROTOC_GEN_GO_TAG)

go install $(PROTOC_GEN_GO_IMP)@$(PROTOC_GEN_GO_TAG)

daosbuild1 · 2024-05-20T18:43:27Z

src/tests/ftest/util/server_utils.py

+        self.log.info("Support collect-log on servers: %s", str(cmd))
+        cmd.set_command(("support", "collect-log"), **kwargs)
+        return run_remote(
+            self.log, self._hosts, cmd.with_exports, timeout=self.collect_log_timeout.value)    


Suggested change

self.log, self._hosts, cmd.with_exports, timeout=self.collect_log_timeout.value)

self.log, self._hosts, cmd.with_exports, timeout=self.collect_log_timeout.value)

daosbuild1 · 2024-05-20T18:43:30Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14409/1/execution/node/204/log

github-actions · 2024-05-20T18:50:28Z

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/b/340244046

jolivier23 · 2024-05-20T21:32:48Z

Could you add a list of backport titles to the description

e.g. backports the following PRs

DAOS-XYZ blah: ..... (# PR number)

That would help understanding the patch

And if you didn't bring in the whole PR, "partial cherry-pick of ...."

Updated patch

daosbuild1 · 2024-05-20T21:42:46Z

src/control/lib/support/README.md

+for debugging purpose.This options is available for `daos_server`, `dmg` and `daos_agent` binaries.
+It will collect the specific logs, config and other DAOS related metrics and system information.
+
+`dmg support collect-log` is the single command, which will initiate the log collection 


Suggested change

`dmg support collect-log` is the single command, which will initiate the log collection

`dmg support collect-log` is the single command, which will initiate the log collection

daosbuild1 · 2024-05-20T21:42:48Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14409/2/execution/node/205/log

Updated patch

daosbuild1 · 2024-05-20T21:50:41Z

src/control/lib/support/README.md

+for debugging purpose.This options is available for `daos_server`, `dmg` and `daos_agent` binaries.
+It will collect the specific logs, config and other DAOS related metrics and system information.
+
+`dmg support collect-log` is the single command, which will initiate the log collection 


Suggested change

`dmg support collect-log` is the single command, which will initiate the log collection

`dmg support collect-log` is the single command, which will initiate the log collection

daosbuild1 · 2024-05-20T21:50:41Z

src/tests/ftest/util/server_utils_base.py

+                self.archive = FormattedParameter("--archive", False)
+                self.extra_logs_dir = FormattedParameter("--extra-logs-dir={}")
+                self.target_host = FormattedParameter("--target-host={}")
+


Suggested change

daosbuild1 · 2024-05-20T21:50:44Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14409/3/execution/node/170/log

Updated patch

daosbuild1 · 2024-05-20T21:54:32Z

src/control/lib/support/README.md

+for debugging purpose.This options is available for `daos_server`, `dmg` and `daos_agent` binaries.
+It will collect the specific logs, config and other DAOS related metrics and system information.
+
+`dmg support collect-log` is the single command, which will initiate the log collection 


Suggested change

`dmg support collect-log` is the single command, which will initiate the log collection

`dmg support collect-log` is the single command, which will initiate the log collection

daosbuild1 · 2024-05-20T21:54:34Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14409/4/execution/node/148/log

Updated patch

daosbuild1

LGTM. No errors found by checkpatch.

jolivier23 · 2024-05-20T22:00:50Z

src/tests/ftest/control/daos_agent_support_collect_log.py

+            Test daos_agent support collect-log command completes successfully.
+
+        :avocado: tags=all,full_regression
+        :avocado: tags=hw,medium


I wonder if these tests actually need hw to pass...

Anyway, with google/2.4 we explicitely disable hardware testing but for a one off run of these tests, you can do this

Test-tag: support pr
Skip-func-hw-test-medium: false

in the last commit. If you want to do this but not making any changes, I suggest

git commit --allow-empty

Also the DCO check wants commits to have Signed-off-by so git commit -s will do that.

Although this port copies the code from master to 2.4, there are issues related to permissions making it non-functional. This is a partial cherry-pick of the following PR's on master: DAOS-10625 control: Create the tool to collect the logs/config for support purpose (#11094) DAOS-13759 control: Update support collect-log tool. (#12906) DAOS-13763 control: Fix daos_metrics collection for support collect-log. (#12555) DAOS-13936 support: Collect the specific logs and Time range log for support (#13325) Signed-off-by: Chris Davis <[email protected]>

daosbuild1

LGTM. No errors found by checkpatch.

cdavis28 requested review from mjmac and jolivier23 May 20, 2024 18:36

daosbuild1 previously requested changes May 20, 2024

View reviewed changes

cdavis28 force-pushed the dev/chrd/collect branch from cfb5da6 to ced5905 Compare May 20, 2024 21:31

daosbuild1 previously requested changes May 20, 2024

View reviewed changes

cdavis28 force-pushed the dev/chrd/collect branch from ced5905 to fe6a957 Compare May 20, 2024 21:48

daosbuild1 previously requested changes May 20, 2024

View reviewed changes

cdavis28 force-pushed the dev/chrd/collect branch from fe6a957 to 2913a20 Compare May 20, 2024 21:51

daosbuild1 previously requested changes May 20, 2024

View reviewed changes

cdavis28 force-pushed the dev/chrd/collect branch from 2913a20 to 746ce35 Compare May 20, 2024 21:57

daosbuild1 reviewed May 20, 2024

View reviewed changes

jolivier23 reviewed May 20, 2024

View reviewed changes

jolivier23 approved these changes May 20, 2024

View reviewed changes

cdavis28 force-pushed the dev/chrd/collect branch from 746ce35 to b9bdc26 Compare May 20, 2024 23:40

daosbuild1 reviewed May 20, 2024

View reviewed changes

cdavis28 merged commit 6d6b3ca into google/2.4 May 21, 2024
33 of 35 checks passed

cdavis28 deleted the dev/chrd/collect branch May 21, 2024 01:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

b/340244046 initial port collect command from master to 2.4 #14409

b/340244046 initial port collect command from master to 2.4 #14409

cdavis28 commented May 20, 2024

jolivier23 commented May 20, 2024

daosbuild1 May 20, 2024

daosbuild1 May 20, 2024

daosbuild1 May 20, 2024

daosbuild1 commented May 20, 2024

github-actions bot commented May 20, 2024

jolivier23 commented May 20, 2024

daosbuild1 May 20, 2024

daosbuild1 commented May 20, 2024

daosbuild1 May 20, 2024

daosbuild1 May 20, 2024

daosbuild1 commented May 20, 2024

daosbuild1 May 20, 2024

daosbuild1 commented May 20, 2024

daosbuild1 left a comment

jolivier23 May 20, 2024

daosbuild1 left a comment

	go install $(PROTOC_GEN_GO_IMP)@$(PROTOC_GEN_GO_TAG)
	go install $(PROTOC_GEN_GO_IMP)@$(PROTOC_GEN_GO_TAG)

	self.log, self._hosts, cmd.with_exports, timeout=self.collect_log_timeout.value)
	self.log, self._hosts, cmd.with_exports, timeout=self.collect_log_timeout.value)

	`dmg support collect-log` is the single command, which will initiate the log collection
	`dmg support collect-log` is the single command, which will initiate the log collection

b/340244046 initial port collect command from master to 2.4 #14409

b/340244046 initial port collect command from master to 2.4 #14409

Conversation

cdavis28 commented May 20, 2024

jolivier23 commented May 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented May 20, 2024

github-actions bot commented May 20, 2024

jolivier23 commented May 20, 2024

Choose a reason for hiding this comment

daosbuild1 commented May 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented May 20, 2024

Choose a reason for hiding this comment

daosbuild1 commented May 20, 2024

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment