Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15431 vos: clear DTX in CoS cache for the one committed by other - b24 #14324

Closed
wants to merge 1 commit into from

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented May 7, 2024

It is possible that the DTX is committed locally via commit-on-share mechanism during some subsequent modification. But such modification may get failure on some remote paraticipant. Then the DTX entry will not be removed from CoS cache under such case because we do not know whether such DTX has already been committed on remote participant(s) successfully or not. Keeping it in CoS cache will allow us to re-try the commit globally sometime later.

Next time, when we re-try to commit such DTX globally, if all remote participants claim as done (return 0 or DER_NONEXIST or DER_ALREADY) successfully, then even if local VOS calims as DER_ALREADY, we still need to remove the DTX entry from CoS cache. Otherwise, we will find such DTX entry in the CoS cache everytime for batched commit (or DTX resync) as to block related process.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

… - b24

It is possible that the DTX is committed locally via commit-on-share
mechanism during some subsequent modification. But such modification
may get failure on some remote paraticipant. Then the DTX entry will
not be removed from CoS cache under such case because we do not know
whether such DTX has already been committed on remote participant(s)
successfully or not. Keeping it in CoS cache will allow us to re-try
the commit globally sometime later.

Next time, when we re-try to commit such DTX globally, if all remote
participants claim as done (return 0 or DER_NONEXIST or DER_ALREADY)
successfully, then even if local VOS calims as DER_ALREADY, we still
need to remove the DTX entry from CoS cache. Otherwise, we will find
such DTX entry in the CoS cache everytime for batched commit (or DTX
resync) as to block related process.

Signed-off-by: Fan Yong <[email protected]>
Copy link

github-actions bot commented May 7, 2024

Bug-tracker data:
Ticket title is 'daos_test/suite.py: test_daos_rebuild_simple: during iteration: Test interrupted by SIGTERM'
Status is 'In Review'
Labels: 'scrubbed,triaged'
https://daosio.atlassian.net/browse/DAOS-15431

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review May 9, 2024 06:30
@Nasf-Fan Nasf-Fan requested review from a team as code owners May 9, 2024 06:30
@Nasf-Fan Nasf-Fan requested review from liuxuezhao and gnailzenh May 10, 2024 07:55
@Nasf-Fan Nasf-Fan added the release-2.4 PR is eventually targeted for 2.4 label May 14, 2024
@Nasf-Fan
Copy link
Contributor Author

No plan for back-port to release/2.4.

@Nasf-Fan Nasf-Fan closed this May 15, 2024
@Nasf-Fan Nasf-Fan deleted the Nasf-Fan/DAOS-15431_b24 branch October 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-2.4 PR is eventually targeted for 2.4
Development

Successfully merging this pull request may close these issues.

3 participants