Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15759 test: Remove utils/cr_demo #14265

Merged
merged 1 commit into from
Apr 29, 2024
Merged

DAOS-15759 test: Remove utils/cr_demo #14265

merged 1 commit into from
Apr 29, 2024

Conversation

shimizukko
Copy link
Contributor

Catastrophic recovery demo scripts that are in utils/cr_demo introduces security vulnerabilities. The scripts are for the CR demo and no longer necessary, so remove them.

Skip-build: true
Skip-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Catastrophic recovery demo scripts that are in utils/cr_demo
introduces security vulnerabilities. The scripts are for the
CR demo and no longer necessary, so remove them.

Skip-build: true
Skip-test: true
Signed-off-by: Makito Kano <[email protected]>
@shimizukko shimizukko marked this pull request as ready for review April 27, 2024 05:03
Copy link

Ticket title is 'Checkmarx: [Python/Medium] - Path Traversal vulnerability in run_demo_aurora.py'
Status is 'Open'
Labels: 'SDLe,triaged'
https://daosio.atlassian.net/browse/DAOS-15759

Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes like this, I don't think we should skip build stages:

Skip-build: true

Just in case something relies on it. But this one looks okay.

Copy link
Contributor

@dinghwah dinghwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files deleted, as planned.

@shimizukko shimizukko requested a review from a team April 29, 2024 21:23
@mchaarawi mchaarawi merged commit b593cea into master Apr 29, 2024
34 checks passed
@mchaarawi mchaarawi deleted the makito/DAOS-15759 branch April 29, 2024 21:27
@mjmac mjmac mentioned this pull request Apr 30, 2024
mjmac pushed a commit that referenced this pull request Apr 30, 2024
Catastrophic recovery demo scripts that are in utils/cr_demo
introduces security vulnerabilities. The scripts are for the
CR demo and no longer necessary, so remove them.

Signed-off-by: Makito Kano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants