Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15685 control: Add logging on metadata/SCM mount #14263

Closed
wants to merge 1 commit into from
Closed

DAOS-15685 control: Add logging on metadata/SCM mount #14263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/control/server/instance_superblock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ func (ei *EngineInstance) WriteSuperblock() error {
// from storage.
func (ei *EngineInstance) ReadSuperblock() error {
if err := ei.MountMetadata(); err != nil {
ei.log.Errorf("unable to mount metadata device: %s", err.Error())
return errors.Wrap(err, "failed to mount control metadata device")
}

Expand Down
5 changes: 4 additions & 1 deletion src/control/server/storage/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ func (p *Provider) MountControlMetadata() error {

if !p.engineStorage.ControlMetadata.HasPath() {
// If there's no control metadata path, we use SCM for control metadata
p.log.Debug("mounting SCM for control metadata")
return p.MountScm()
}

Expand All @@ -189,6 +190,7 @@ func (p *Provider) ControlMetadataIsMounted() (bool, error) {
p.log.Debugf("control metadata config: %+v", p.engineStorage.ControlMetadata)
if !p.engineStorage.ControlMetadata.HasPath() {
// If there's no control metadata path, we use SCM for control metadata
p.log.Debug("checking if SCM is mounted")
return p.ScmIsMounted()
}

Expand All @@ -197,6 +199,7 @@ func (p *Provider) ControlMetadataIsMounted() (bool, error) {
return false, nil
}

p.log.Debug("checking if control metadata directory is mounted")
return p.Sys.IsMounted(p.engineStorage.ControlMetadata.Path)
}

Expand Down Expand Up @@ -251,7 +254,7 @@ func (p *Provider) GetScmUsage() (*ScmMountPoint, error) {
func (p *Provider) ScmIsMounted() (bool, error) {
cfg, err := p.GetScmConfig()
if err != nil {
return false, err
return false, errors.Wrap(err, "getting SCM config")
}
return p.Sys.IsMounted(cfg.Scm.MountPoint)
}
Expand Down
Loading