Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15713 chk: fix kinds of coverity issues #14242

Merged
merged 1 commit into from
Apr 30, 2024
Merged

DAOS-15713 chk: fix kinds of coverity issues #14242

merged 1 commit into from
Apr 30, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Apr 24, 2024 •
edited
Loading

CID: 2555541 2555529 2555517 2555545 2555527

Test-tag: cat_recov

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@Nasf-Fan
DAOS-15713 chk: fix kinds of coverity issues
2cbd56b 
CID: 2555541 2555529 2555524 2555517 2555545 2555527

Test-tag: cat_recov

Signed-off-by: Fan Yong <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14242/1/display/redirect

@github-actions GitHub Actions
Copy link

Ticket title is '[coverity] 2555541 Free of array-typed value'
Status is 'In Progress'
Labels: 'coverity'
https://daosio.atlassian.net/browse/DAOS-15713

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14242/2/execution/node/1403/log

@Nasf-Fan
Copy link
Contributor Author

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14242/2/execution/node/1403/log

This is caused by DAOS-15745, not related with the patch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14242/2/execution/node/1449/log

@Nasf-Fan
Copy link
Contributor Author

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14242/2/execution/node/1449/log

Test_daos_rebuild_simple failed for DAOS-15124, not related with the patch.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review April 25, 2024 07:43
@Nasf-Fan Nasf-Fan requested review from kjacque, wangshilong and liw and removed request for kjacque April 25, 2024 07:43
@Nasf-Fan Nasf-Fan added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 25, 2024
@Nasf-Fan Nasf-Fan requested review from a team and gnailzenh April 26, 2024 01:04
@Nasf-Fan Nasf-Fan added the priority Ticket has high priority (automatically managed) label Apr 29, 2024
@Nasf-Fan Nasf-Fan requested a review from a team April 29, 2024 14:48
@gnailzenh gnailzenh merged commit 6a2c3e4 into master Apr 30, 2024
49 of 53 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-15713 branch April 30, 2024 06:11
@mjmac mjmac mentioned this pull request Apr 30, 2024
Closed
mjmac pushed a commit that referenced this pull request Apr 30, 2024
@Nasf-Fan @mjmac
DAOS-15713 chk: fix kinds of coverity issues (#14242)
56103f4 
CID: 2555541 2555529 2555524 2555517 2555545 2555527

Signed-off-by: Fan Yong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacque kjacque kjacque approved these changes

@gnailzenh gnailzenh gnailzenh approved these changes

@liw liw liw approved these changes

@wangshilong wangshilong Awaiting requested review from wangshilong

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nasf-Fan @daosbuild1 @liw @gnailzenh @kjacque