Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15048 control: Display NSID only when populated in storage query #14239

Merged
merged 1 commit into from
Apr 27, 2024
Merged

DAOS-15048 control: Display NSID only when populated in storage query #14239

merged 1 commit into from
Apr 27, 2024

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Apr 24, 2024 •
edited
Loading

For certain situations a zero value NVMe namespace ID will be returned
in dmg output, in this case it should be omitted from display output as
valid values are non-zero.

Features: control
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr
DAOS-15048 control: Display NSID only when populated in storage query
9b1b079 
Features: control
Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr requested review from a team as code owners April 24, 2024 12:10
@tanabarr tanabarr self-assigned this Apr 24, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'NSID of unplugged device should be empty'
Status is 'In Review'
Labels: 'hotplug,scrubbed'
https://daosio.atlassian.net/browse/DAOS-15048

@tanabarr tanabarr added control-plane work on the management infrastructure of the DAOS Control Plane go Pull requests that update Go code usability Changes specific to user facing tools or behaviour. labels Apr 24, 2024
@tanabarr tanabarr requested review from mjmac, kjacque and knard38 April 24, 2024 12:13
knard38
knard38 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@knard38
Copy link
Contributor

knard38 commented Apr 25, 2024

@tanabarr , I take the initiative to restart the failed steps (i.e. ShellCheck and pylint GitHub actions) as they have failed on temporary unavailable external resources (i.e. external debian repos).

knard38
knard38 reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT

src/control/cmd/dmg/pretty/storage_test.go Show resolved Hide resolved
@tanabarr tanabarr requested a review from a team April 25, 2024 19:22
@tanabarr
Copy link
Contributor Author

@daos-stack/daos-gatekeeper can we land this PR please?

@tanabarr
Copy link
Contributor Author

@daos-stack/daos-gatekeeper ping

@ashleypittman ashleypittman merged commit 1df98ea into master Apr 27, 2024
57 checks passed
@ashleypittman ashleypittman deleted the tanabarr/control-dmg-hide-zero-nsid branch April 27, 2024 09:11
@mjmac mjmac mentioned this pull request Apr 30, 2024
Closed
mjmac pushed a commit that referenced this pull request Apr 30, 2024
@tanabarr @mjmac
DAOS-15048 control: Display NSID only when populated in storage query (…
a034f2c 
…#14239)

For certain situations a zero value NVMe namespace ID will be returned
in dmg output, in this case it should be omitted from display output as
valid values are non-zero.

Signed-off-by: Tom Nabarro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@kjacque kjacque kjacque approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@tanabarr tanabarr

Labels
control-plane work on the management infrastructure of the DAOS Control Plane go Pull requests that update Go code usability Changes specific to user facing tools or behaviour.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanabarr @knard38 @kjacque @ashleypittman