DAOS-15717 bug: Fix memory leak cid 2555536 #14231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix mem leak for coverity 2555536 Required-githooks: true Signed-off-by: Alexander A Oganezov <[email protected]>
soumagne
reviewed
Apr 23, 2024
src/mgmt/cli_mgmt.c
Outdated
| @@ -240,16 +240,19 @@ get_env_deprecated(char **val, const char *new_env, const char *old_env) | |||
| D_WARN("Both %s and %s are set! Deprecated %s (%s) will be ignored\n", | |||
| new_env, old_env, old_env, old); | |||
| *val = new; | |||
| return 0; | |||
| D_GOTO(out, rc_new = 0); | |||
There was a problem hiding this comment.
is rc_new not already equal to 0 ?
There was a problem hiding this comment.
sure, but in D_GOTO i prefer to set value explicitly rather than doing something like D_GOTO(out, rc_new);
|
Ticket title is '[coverity] 2555536 Resource leak' |
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14231/1/testReport/ |
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14231/2/testReport/ |
Required-githooks: true Signed-off-by: Alexander A Oganezov <[email protected]>
soumagne
approved these changes
Apr 24, 2024
kjacque
approved these changes
Apr 24, 2024
mjmac
pushed a commit
that referenced
this pull request
Apr 30, 2024
- Fix mem leak for coverity 2555536 Signed-off-by: Alexander A Oganezov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required-githooks: true
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: