Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15499 dtx: cleanup DTX for failure #14224

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Apr 23, 2024

That will drop partial modification, remove the pinned DTX entry, evict related stale cache.

Test-tag: test_daos_vol_mpich test_ior_small test_mdtest_small test_osa_online_drain_oclass test_create_pool_quantity test_aggregation_punching test_smallfilecount
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium: true
Quick-Functional: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Apr 23, 2024

Ticket title is 'DAOS server segmentation fault during daos_racer test'
Status is 'In Review'
Labels: 'scrubbed,triaged'
https://daosio.atlassian.net/browse/DAOS-15499

That will drop partial modification, remove the pinned DTX entry,
evict related stale cache.

Test-tag: test_daos_vol_mpich test_ior_small test_mdtest_small test_osa_online_drain_oclass test_create_pool_quantity test_aggregation_punching test_smallfilecount
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium: true
Quick-Functional: true

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15499_f1 branch from c1d5485 to 582efb5 Compare April 23, 2024 09:00
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14224/2/execution/node/741/log

Priority: 2

Required-githooks: true

Signed-off-by: Mohamad Chaarawi <[email protected]>
@mchaarawi
Copy link
Contributor

looks like the PR does resolve the issues seen in the tests (the 1 failure is a different / unrelated issue).
I repushed to trigger PR testing with high priority so it can be landed.
(still in draft state though and needs reviewers)

@Nasf-Fan
Copy link
Contributor Author

NLT on EL 8.8 failed as following, I will re-trigger the test.

03:54:18 Copied 0 artifacts from "daos-stack » daos » PR-14224" build number 3
1
Failed to copy artifacts from daos-stack/daos/PR-14224 with filter: stage_status/null-null.status

@Nasf-Fan Nasf-Fan marked this pull request as ready for review April 24, 2024 12:46
@Nasf-Fan Nasf-Fan requested review from a team as code owners April 24, 2024 12:46
@Nasf-Fan Nasf-Fan requested review from gnailzenh and mchaarawi April 24, 2024 12:47
@mchaarawi mchaarawi merged commit ddaf6ce into master Apr 24, 2024
51 checks passed
@mchaarawi mchaarawi deleted the Nasf-Fan/DAOS-15499_f1 branch April 24, 2024 16:43
mjmac pushed a commit that referenced this pull request Apr 30, 2024
That will drop partial modification, remove the pinned DTX entry,
evict related stale cache.

Signed-off-by: Fan Yong <[email protected]>
@mjmac mjmac mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants