Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15661 object: set correct map version for layout create #14222

Merged
merged 1 commit into from
Apr 30, 2024
Merged

DAOS-15661 object: set correct map version for layout create #14222

merged 1 commit into from
Apr 30, 2024

Conversation

liuxuezhao
Copy link
Contributor

In obj_layout_create, it get pl_map by pl_map_find() without holding dp_map_lock, and then set "omd_ver = dc_pool_get_version(pool)". The map version of the pl_map possibly not same as dc_pool_get_version() if another thread refreshed the dc_pool's pool map.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao
DAOS-15661 object: set correct map version for layout create
f52c7e9 
In obj_layout_create, it get pl_map by pl_map_find() without holding
dp_map_lock, and then set "omd_ver = dc_pool_get_version(pool)".
The map version of the pl_map possibly not same as dc_pool_get_version()
if another thread refreshed the dc_pool's pool map.

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
@liuxuezhao liuxuezhao requested review from a team as code owners April 23, 2024 08:31
@github-actions GitHub Actions
Copy link

Ticket title is 'pool map version issue in race condition '
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-15661

@liuxuezhao liuxuezhao requested review from liw and Nasf-Fan and removed request for a team April 23, 2024 08:31
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14222/1/execution/node/1430/log

@liuxuezhao
Copy link
Contributor Author

only one test failure due to https://daosio.atlassian.net/browse/DAOS-15431

@liuxuezhao liuxuezhao requested a review from wangshilong April 25, 2024 08:40
@liuxuezhao liuxuezhao requested a review from a team April 26, 2024 01:31
@liuxuezhao liuxuezhao added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 26, 2024
@gnailzenh gnailzenh merged commit e7aa7a8 into master Apr 30, 2024
48 of 51 checks passed
@gnailzenh gnailzenh deleted the lxz/layout_ver_fix branch April 30, 2024 07:18
@mjmac mjmac mentioned this pull request Apr 30, 2024
Closed
mjmac pushed a commit that referenced this pull request Apr 30, 2024
@liuxuezhao @mjmac
DAOS-15661 object: set correct map version for layout create (#14222)
570cd8f 
In obj_layout_create, it get pl_map by pl_map_find() without holding
dp_map_lock, and then set "omd_ver = dc_pool_get_version(pool)".
The map version of the pl_map possibly not same as dc_pool_get_version()
if another thread refreshed the dc_pool's pool map.

Signed-off-by: Xuezhao Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnailzenh gnailzenh gnailzenh approved these changes

@wangshilong wangshilong wangshilong approved these changes

@liw liw liw approved these changes

@Nasf-Fan Nasf-Fan Awaiting requested review from Nasf-Fan

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuxuezhao @daosbuild1 @liw @wangshilong @gnailzenh