Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15651 control: fail fast on invalid rank for integrate #14213

Merged
merged 1 commit into from
May 1, 2024

Conversation

cdavis28
Copy link
Contributor

check rank against membership before issuing rank update for integrate.
Also fix a minor unit test bug related to getting syslog

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

check rank against membership before issuing rank update
for integrate.
Also fix a minor unit test bug related to getting syslog

Signed-off-by: Chris Davis <[email protected]>
@cdavis28 cdavis28 requested review from mjmac and jolivier23 April 22, 2024 18:53
@cdavis28 cdavis28 marked this pull request as ready for review April 22, 2024 18:55
@cdavis28 cdavis28 requested review from a team as code owners April 22, 2024 18:55
@cdavis28
Copy link
Contributor Author

Moved from #14165

Copy link

Ticket title is 'dmg pool reintegrate with an invalid rank will timeout'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-15651

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14213/1/execution/node/1497/log

@cdavis28
Copy link
Contributor Author

I can't get the details on why those two tests failed. It leads to an Intel url that either is down or I simply don't have access to.
@jolivier23 @mjmac ideas?

@tanabarr
Copy link
Contributor

looks like this failed on a known issue: DAOS_Rebuild_Simple so maybe unrelated to the PR?

@mjmac
Copy link
Contributor

mjmac commented Apr 23, 2024

Yeah, my remote desktop connection is pretty flaky today, but I was able to determine that the failure seemed to be due to a missing cmocka file in the rebuild test suite. Definitely not related to this relatively small control plane change.

@mjmac mjmac added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 25, 2024
@mjmac mjmac requested a review from a team April 25, 2024 15:24
@cdavis28
Copy link
Contributor Author

@mjmac is there someone we need to ping to make this happen?

@mjmac
Copy link
Contributor

mjmac commented Apr 30, 2024

@mjmac is there someone we need to ping to make this happen?

Pinging @jolivier23... :)

@jolivier23 jolivier23 merged commit 90852a8 into master May 1, 2024
49 of 51 checks passed
@jolivier23 jolivier23 deleted the cdavis28/DAOS-15651 branch May 1, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

6 participants