Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15686 gurt: Accept ERROR as a log mask string #14211

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Apr 22, 2024

A change further up in the stack revealed that "ERROR" wasn't accepted as a log mask string at the engine level.

Test-tag: pr test_version

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

A change further up in the stack revealed that "ERROR" wasn't
accepted as a log mask string at the engine level.

Test-tag: pr test_version

Required-githooks: true

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque self-assigned this Apr 22, 2024
@kjacque kjacque requested a review from a team as a code owner April 22, 2024 16:43
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-15686

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14211/1/testReport/

@tanabarr tanabarr requested a review from a team April 23, 2024 10:57
@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 23, 2024
@tanabarr
Copy link
Contributor

@daos-stack/daos-gatekeeper can we please force land this PR as it will unblock testing on others. CONT 35 test failure on https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14211/1/tests looks unrelated.

@johannlombardi johannlombardi merged commit 899cdd2 into master Apr 23, 2024
52 of 54 checks passed
@johannlombardi johannlombardi deleted the kjacque/log-mask-error-str branch April 23, 2024 12:06
mjmac pushed a commit that referenced this pull request May 22, 2024
A change further up in the stack revealed that "ERROR" wasn't
accepted as a log mask string at the engine level.

Signed-off-by: Kris Jacque <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

6 participants