Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15655 test: stop passing server group #14201

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

daltonbohning
Copy link
Contributor

Test-tag: pr ContinuousWrite SpaceRb MultipleContainerDelete PerServerFaultDomainTest TestWithTelemetryIOLatency AgentFailure NetworkFailureTest ServerRankFailure TargetFailure EcodSpaceUsage ParallelIo IorCrash NvmeEnospace NvmeFragmentation NvmeIoVerification NvmeIo NvmePoolCapacity PoolMembershipTest ObjectMetadata datamover soak_smoke NvmePoolCapacity OSAOnlineParallelTest DiskFailureTest,-manual NvmePoolExtend OSAOfflineDrain OSAOfflineExtend OSAOfflineParallelTest OSAOfflineReintegration OSAOnlineDrain OSAOnlineDrain OSAOnlineExtend OSAOnlineExtend OSAOnlineReintegration NvmeEnospace NvmeFault NvmeHealth OSAOfflineDrain OSAOfflineReintegration EcodAggregationOff EcodOnlineMultFail EcodAggregationOffRebuild mdtest ior NvmePoolExclude NvmeFaultReintegrate IoctlPoolHandles ReplayTests BasicClientTelemetry WalMetrics DaosAggregationMultiPoolCont VerifyPoolSpace
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Test-tag: pr ContinuousWrite SpaceRb MultipleContainerDelete PerServerFaultDomainTest TestWithTelemetryIOLatency AgentFailure NetworkFailureTest ServerRankFailure TargetFailure EcodSpaceUsage ParallelIo IorCrash NvmeEnospace NvmeFragmentation NvmeIoVerification NvmeIo NvmePoolCapacity PoolMembershipTest ObjectMetadata datamover soak_smoke NvmePoolCapacity OSAOnlineParallelTest DiskFailureTest,-manual NvmePoolExtend OSAOfflineDrain OSAOfflineExtend OSAOfflineParallelTest OSAOfflineReintegration OSAOnlineDrain OSAOnlineDrain OSAOnlineExtend OSAOnlineExtend OSAOnlineReintegration NvmeEnospace NvmeFault NvmeHealth OSAOfflineDrain OSAOfflineReintegration EcodAggregationOff EcodOnlineMultFail EcodAggregationOffRebuild mdtest ior NvmePoolExclude NvmeFaultReintegrate IoctlPoolHandles ReplayTests BasicClientTelemetry WalMetrics DaosAggregationMultiPoolCont VerifyPoolSpace
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Apr 19, 2024
Copy link

Ticket title is 'Using a different system name (other than daos_server) does not work.'
Status is 'Open'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-15655

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14201/1/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14201/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14201/2/testReport/

@daltonbohning daltonbohning marked this pull request as ready for review April 23, 2024 14:29
@daltonbohning daltonbohning requested review from a team as code owners April 23, 2024 14:29
@daltonbohning
Copy link
Contributor Author

daltonbohning commented Apr 23, 2024

Single failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14201/2/tests
Is for a manual test not expected to pass in CI

:avocado: tags=all,manual

Intentionally made a manual test:
https://daosio.atlassian.net/browse/DAOS-13157

@daltonbohning daltonbohning requested a review from a team April 23, 2024 15:56
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 23, 2024
@daltonbohning daltonbohning requested a review from a team April 30, 2024 14:35
@daltonbohning
Copy link
Contributor Author

Please use this description for merge

Stop passing --dfs.group to ior and mdtest since they get this information from the agent.

@phender phender merged commit 88406d4 into master Apr 30, 2024
43 of 45 checks passed
@phender phender deleted the dbohning/daos-15655-ftest branch April 30, 2024 14:39
daltonbohning added a commit that referenced this pull request Apr 30, 2024
Test-tag: ContinuesAfterStop
Skip-unit-tests: true
Skip-fault-injection-test: true

Fix an uncaught merge confclit between #14100 and #14201

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
phender pushed a commit that referenced this pull request Apr 30, 2024
Fix an uncaught merge confclit between #14100 and #14201

Signed-off-by: Dalton Bohning <[email protected]>
@mjmac mjmac mentioned this pull request Apr 30, 2024
mjmac pushed a commit that referenced this pull request Apr 30, 2024
Stop passing --dfs.group to ior and mdtest since they get this information from the agent.

Signed-off-by: Dalton Bohning <[email protected]>
mjmac pushed a commit that referenced this pull request Apr 30, 2024
Fix an uncaught merge confclit between #14100 and #14201

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request May 14, 2024
The group argument was removed by #14201.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request May 14, 2024
The group argument was removed by #14201.

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

6 participants