Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15659 test: fix local ftest prefix #14173

Merged
merged 1 commit into from
Apr 29, 2024
Merged

DAOS-15659 test: fix local ftest prefix #14173

merged 1 commit into from
Apr 29, 2024

Conversation

daltonbohning
Copy link
Contributor

@daltonbohning daltonbohning commented Apr 16, 2024 •
edited
Loading

Test-tag: pr
Skip-unit-tests: true
Skip-fault-injection-test: true

PR #13565 accidentally broke how ftest determines the prefix from .build_vars.json because it is no longer installed.

Eliminate the need for .build_vars.json in ftest entirely by using
shutil.which("daos") and support setting DAOS_TEST_PREFIX

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Apr 16, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'local ftest uses the wrong build_vars.json file'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15659

@daltonbohning daltonbohning force-pushed the dbohning/daos-15659 branch 2 times, most recently from 6e02774 to b0fceef Compare April 16, 2024 21:52
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/3/execution/node/993/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/3/execution/node/1039/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15659 branch 3 times, most recently from 581627b to b283818 Compare April 23, 2024 15:50
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/6/execution/node/782/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/7/execution/node/426/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/7/execution/node/324/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/7/execution/node/430/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/7/execution/node/433/log

@daltonbohning
Copy link
Contributor Author

Approach doesn't work on Aurora

2024/04/24 07:01:59 DEBUG                      run_local: Running on aurora-daos-0790 with a 5 timeout: command -v daos
2024/04/24 07:01:59 DEBUG                      run_local: Command 'command -v daos' encountered unknown error
2024/04/24 07:01:59 DEBUG                      run_local: [Errno 2] No such file or directory: 'command': 'command'

@daltonbohning daltonbohning force-pushed the dbohning/daos-15659 branch 2 times, most recently from 62f6cb6 to d808bfc Compare April 25, 2024 21:57
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/10/execution/node/751/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15659 branch 2 times, most recently from 2008472 to 2d7ef88 Compare April 26, 2024 15:24
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/12/execution/node/781/log

@daltonbohning
DAOS-15659 test: fix local ftest prefix
baee33f 
Test-tag: pr
Skip-unit-tests: true
Skip-fault-injection-test: true

PR #13565 accidentally broke how ftest determines the prefix from
.build_vars.json because it is no longer installed.

Eliminate the need for .build_vars.json in ftest entirely by using
shutil.which("daos") and support setting DAOS_TEST_PREFIX

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14173/13/execution/node/992/log

@daltonbohning
Copy link
Contributor Author

Failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14173/13/tests
is
https://daosio.atlassian.net/browse/DAOS-15431

@daltonbohning daltonbohning marked this pull request as ready for review April 29, 2024 15:43
@daltonbohning daltonbohning requested review from a team as code owners April 29, 2024 15:43
rpadma2
rpadma2 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@rpadma2 rpadma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daltonbohning daltonbohning requested a review from a team April 29, 2024 21:07
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Apr 29, 2024
@phender phender merged commit 40fab0c into master Apr 29, 2024
43 of 45 checks passed
@phender phender deleted the dbohning/daos-15659 branch April 29, 2024 21:31
@mjmac mjmac mentioned this pull request Apr 30, 2024
Closed
mjmac pushed a commit that referenced this pull request Apr 30, 2024
@daltonbohning @mjmac
DAOS-15659 test: fix local ftest prefix (#14173)
6196dce 
PR #13565 accidentally broke how ftest determines the prefix from
.build_vars.json because it is no longer installed.

Eliminate the need for .build_vars.json in ftest entirely by using
shutil.which("daos") and support setting DAOS_TEST_PREFIX

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@rpadma2 rpadma2 rpadma2 approved these changes

@ashleypittman ashleypittman Awaiting requested review from ashleypittman

@shimizukko shimizukko Awaiting requested review from shimizukko

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @daosbuild1 @rpadma2 @phender