Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15605 rsvc: Create rsvc with VOS DF version #14156

Merged
merged 1 commit into from
Apr 18, 2024
Merged

DAOS-15605 rsvc: Create rsvc with VOS DF version #14156

merged 1 commit into from
Apr 18, 2024

Conversation

liw
Copy link
Contributor

@liw liw commented Apr 12, 2024

If a pool with an old layout version is served by a DAOS version with a new default layout version, for instance, a 2.4-layout pool served by DAOS 2.5, then any new VOS pools created for this DAOS pool must use the old layout, or downgrading back to the old DAOS version would become impossible.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liw
DAOS-15605 rsvc: Create rsvc with VOS DF version
252309a 
If a pool with an old layout version is served by a DAOS version with a
new default layout version, for instance, a 2.4-layout pool served by
DAOS 2.5, then any new VOS pools created for this DAOS pool must use the
old layout, or downgrading back to the old DAOS version would become
impossible.

Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
@github-actions GitHub Actions
Copy link

Ticket title is 'daos 2.4 to 2.6 interop assertion: vos_pool_upgrade() Assertion 'version > pool_df->pd_version && version <= POOL_DF_VERSION' failed: Invalid pool upgrade version 25, current version is 26'
Status is 'In Progress'
Labels: 'interop,scrubbed'
https://daosio.atlassian.net/browse/DAOS-15605

@liw liw marked this pull request as ready for review April 15, 2024 01:17
@liw liw requested review from a team as code owners April 15, 2024 01:17
@liw liw requested review from wangshilong and kccain April 15, 2024 01:18
@liw
Copy link
Contributor Author

liw commented Apr 15, 2024

Tested manually upgrading software from 2.4.2 to this PR (+ Ken's #14091) with pools that were not upgraded to the new global version:

  • PS membership changes (for better distribution among fault domains) after the software upgrade worked fine. And engine logs showed that the new VOS files were created with VOS DF version 25 instead of 26.
  • Pool extend did create new VOS files with VOS DF version 26. This problem will not be addressed for the moment.
  • Downgrading hit an MS problem: DAOS-15639.

kccain
kccain approved these changes Apr 16, 2024
View reviewed changes
src/rsvc/srv.c
@@ -1169,11 +1173,12 @@ bcast_create(crt_opcode_t opc, bool filter_invert, d_rank_list_t *filter_ranks,
* \param[in] create create replicas first
* \param[in] bootstrap start with an initial list of replicas
* \param[in] size size of each replica in bytes if \a create
* \param[in] vos_df_version version of VOS durable format if \a create
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change requested in this patch. I don't think we have any callers that specify create=false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kccain, good observation. Unfortunately, the CR landing has changed that: There's a non-create caller in rdbt_dictate_handler. Once the base branch lands, I will have to rebase this branch and fix the conflicts with the CR landing. We'll then have the non-create caller.

@gnailzenh gnailzenh merged commit 655d23a into liw/vos-layout Apr 18, 2024
48 of 49 checks passed
@gnailzenh gnailzenh deleted the liw/rsvc-layout branch April 18, 2024 12:42
gnailzenh added a commit that referenced this pull request Apr 18, 2024
@gnailzenh
Revert "DAOS-15605 rsvc: Create rsvc with VOS DF version (#14156)"
0db5236 
This reverts commit 655d23a.
@gnailzenh gnailzenh restored the liw/rsvc-layout branch April 18, 2024 12:44
@liw liw deleted the liw/rsvc-layout branch April 19, 2024 05:42
gnailzenh pushed a commit that referenced this pull request Apr 25, 2024
@liw
DAOS-15605 vos: Add version param to pool create (#14133)
d7e8318 
vos: Add version param to pool create

In a DAOS pool using the old pool global version, we need to create new
VOS pools using the old DF version. See the Jira ticket for the details.
This patch adds a version parameter to vos_pool_create and
vos_pool_create_ex.

rsvc: Create rsvc with VOS DF version (#14156)

If a pool with an old layout version is served by a DAOS version with a
new default layout version, for instance, a 2.4-layout pool served by
DAOS 2.5, then any new VOS pools created for this DAOS pool must use the
old layout, or downgrading back to the old DAOS version would become
impossible.

Signed-off-by: Li Wei <[email protected]>
mjmac pushed a commit that referenced this pull request Apr 30, 2024
@liw @mjmac
DAOS-15605 vos: Add version param to pool create (#14133)
488b070 
vos: Add version param to pool create

In a DAOS pool using the old pool global version, we need to create new
VOS pools using the old DF version. See the Jira ticket for the details.
This patch adds a version parameter to vos_pool_create and
vos_pool_create_ex.

rsvc: Create rsvc with VOS DF version (#14156)

If a pool with an old layout version is served by a DAOS version with a
new default layout version, for instance, a 2.4-layout pool served by
DAOS 2.5, then any new VOS pools created for this DAOS pool must use the
old layout, or downgrading back to the old DAOS version would become
impossible.

Signed-off-by: Li Wei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kccain kccain kccain approved these changes

@gnailzenh gnailzenh gnailzenh approved these changes

@wangshilong wangshilong wangshilong approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liw @wangshilong @gnailzenh @kccain