Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-2145 Warnings-ng 11.2.2 modified API #14111

Merged
merged 2 commits into from
Apr 4, 2024
Merged

SRE-2145 Warnings-ng 11.2.2 modified API #14111

merged 2 commits into from
Apr 4, 2024

Conversation

JohnMalmberg
Copy link
Contributor

Warnings-ng 11.2.2 removed the ignoreFailedBuilds parameter from the recordIssues Step.

Doc-only: false

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@JohnMalmberg JohnMalmberg requested a review from a team as a code owner April 3, 2024 22:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Errors are component not formatted correctly,Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-2145

@JohnMalmberg
SRE-2145 Warnings-ng 11.2.2 modified API
e0c36a5 
Warnings-ng 11.2.2 removed the ignoreFailedBuilds parameter from the
recordIssues Step.

Required-githooks: true

Signed-off-by: John E. Malmberg <[email protected]>
@JohnMalmberg
Copy link
Contributor Author

Gatekeeper, this is the fix needed to get CI working again. Until it lands, and PRs are rebased against it, all CI jobs will fail.

ryon-jensen
ryon-jensen previously approved these changes Apr 4, 2024
View reviewed changes
ashleypittman
ashleypittman reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@ashleypittman ashleypittman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a detailed comment on the ticket, but I don't think this is sufficient or will work well. This change alone without making the corresponding changes to add back in the functionality via the alternate API will mean that failed jobs are used as reference builds and therefore when there are failed master builds (which is often) then PRs will report all warnings as new and themselves fail.

It may be worth landing this in the very short term to unblock other work but this will want fixing properly within days if we do that, and given this PR has negative comments which are provably incorrect about other projects then I would prefer us to fix this properly, or at least remove the comments before landing.

Jenkinsfile Outdated
@@ -782,7 +782,9 @@ pipeline {
valgrind_stash: 'el8-gcc-nlt-memcheck'
recordIssues enabledForFailure: true,
failOnError: false,
ignoreFailedBuilds: true,
// parameter below removed with the warnings-ng 11.2.2
// possibly by mistake.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jenkinsci/warnings-ng-plugin/releases/tag/v11.0.0 states that the change in API was deliberate.

Copy link
Contributor

@phender phender Apr 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should just remove the parameter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that would be best in the short term.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14111/2/execution/node/1541/log

@JohnMalmberg
SRE-2145 Remove comments
efeecd3 
Signed-off-by: John E. Malmberg <[email protected]>
@phender
Copy link
Contributor

phender commented Apr 4, 2024

Landing based upon the success of the previous build: https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14111/2.

@phender phender merged commit 2764c47 into master Apr 4, 2024
36 of 42 checks passed
@phender phender deleted the jemalmbe/sre-2145 branch April 4, 2024 15:34
brianjmurrell pushed a commit that referenced this pull request Apr 8, 2024
@JohnMalmberg @brianjmurrell
SRE-2145 Warnings-ng 11.2.2 modified API (#14111)
9427185 
Warnings-ng 11.2.2 removed the ignoreFailedBuilds parameter from the
recordIssues Step.

Signed-off-by: John E. Malmberg <[email protected]>
daltonbohning pushed a commit that referenced this pull request Apr 9, 2024
@brianjmurrell
SRE-2145 Warnings-ng 11.2.2 modified API (#14111) (#14132)
8d4a74b 
Warnings-ng 11.2.2 removed the ignoreFailedBuilds parameter from the
recordIssues Step.

Signed-off-by: John E. Malmberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@ashleypittman ashleypittman ashleypittman approved these changes

@ryon-jensen ryon-jensen ryon-jensen left review comments

@brianjmurrell brianjmurrell Awaiting requested review from brianjmurrell

@NiuYawei NiuYawei Awaiting requested review from NiuYawei

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohnMalmberg @daosbuild1 @phender @ashleypittman @ryon-jensen