Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15136 client: Switch to using libfused #14077

Merged
merged 38 commits into from
Jan 16, 2025
Merged

DAOS-15136 client: Switch to using libfused #14077

merged 38 commits into from
Jan 16, 2025

Conversation

jolivier23
Copy link
Contributor

@jolivier23 jolivier23 commented Mar 28, 2024 •
edited
Loading

Switch to using libfused instead of libfuse3

This enables the following:

  1. customization of libfuse for dfuse use case
  2. Ability to release the library without breaking other fuse users.

fused is a fork of libfuse that renames
the library and header file directory.

Change-Id: I382b96a17a8d503d6cf7321b57050e7ab0c187d4

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

Ticket title is 'we build a libfuse rpm but there is no matching developer build'
Status is 'In Progress'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-15136

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/354/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/327/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/287/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/351/log

@jolivier23 jolivier23 force-pushed the jvolivie/fused branch 2 times, most recently from 825db6d to 3105249 Compare March 28, 2024 01:27
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/341/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/369/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/353/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/270/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/309/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/355/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/287/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/364/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/350/log

@jolivier23
DAOS-15136 client: Switch to using libfused
df7aadc 
Switch to using libfused instead of libfuse3

PR-repos: fused@PR-1:28

Required-githooks: true

Change-Id: I382b96a17a8d503d6cf7321b57050e7ab0c187d4
Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
Merge branch 'master' into jvolivie/fused
7bf9fb8 
Required-githooks: true

Change-Id: Iddf5882e12161746511e598b3cb4ae380af35683
@jolivier23
PR-repos: fused@1:28
20bf3b6 
Required-githooks: true

Change-Id: Icdd7235f8a93363ee7cc33a1adb5e3c43956c4aa
Signed-off-by: Jeff Olivier <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/326/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/345/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/329/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/338/log

@jolivier23 jolivier23 requested review from a team and removed request for ashleypittman and brianjmurrell January 10, 2025 19:58
@jolivier23
Copy link
Contributor Author

Copyright warnings are wrong because it's only been merged this year.

@jolivier23 jolivier23 added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 10, 2025
@mchaarawi
Copy link
Contributor

let's get a review from release team before landing this

mchaarawi
mchaarawi previously approved these changes Jan 10, 2025
View reviewed changes
@jolivier23
Use static library
5752261 
Features: dfuse
Allow-unstable-build: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 dismissed stale reviews from mchaarawi, wangdi1, and johannlombardi via 5752261 January 12, 2025 00:03
@jolivier23 jolivier23 removed the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 12, 2025
@jolivier23
Empty commit to retest
02e8a79 
Features: dfuse
Allow-unstable-test: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
Try again to see if it picks up #4
3487bc6 
Features: dfuse
Allow-unstable-test: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
Test with static library
0f3267e 
Test-tag: dfuse
Allow-unstable-test: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
Test-tag: dfuse
dae46c8 
Allow-unstable-test: true

Signed-off-by: Jeff Olivier <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14077/34/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/34/execution/node/1425/log

@jolivier23
Merge remote-tracking branch 'comm/master' into jvolivie/fused
e5e09cb
@jolivier23
Retest after sync
9937f33 
Test-tag: dfuse
Allow-unstable-test: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 merged commit df759a3 into master Jan 16, 2025
74 of 76 checks passed
@jolivier23 jolivier23 deleted the jvolivie/fused branch January 16, 2025 05:53
jolivier23 added a commit that referenced this pull request Jan 21, 2025
@jolivier23 @ashleypittman
DAOS-15136 client: Switch to using libfused (#14077)
c012064 
Switch to using libfused instead of libfuse3

This enables the following:

customization of libfuse for dfuse use case
Ability to release the library without breaking other fuse users.
fused is a fork of libfuse that renames
the library and header file directory.

Allow-unstable-test: true
Features: dfuse

Change-Id: If6d2abe9dd4d02fe6b78c92c9b091cbad1838494
Signed-off-by: Jeff Olivier <[email protected]>
Co-authored-by: Ashley Pittman <[email protected]>
jolivier23 added a commit that referenced this pull request Jan 21, 2025
@jolivier23 @ashleypittman
DAOS-15136 client: Switch to using libfused (#14077)
069b34a 
Switch to using libfused instead of libfuse3

This enables the following:

customization of libfuse for dfuse use case
Ability to release the library without breaking other fuse users.
fused is a fork of libfuse that renames
the library and header file directory.

Allow-unstable-test: true
Features: dfuse
Skip-func-hw-test: false

Change-Id: If6d2abe9dd4d02fe6b78c92c9b091cbad1838494
Signed-off-by: Jeff Olivier <[email protected]>
Co-authored-by: Ashley Pittman <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Jan 22, 2025
@jolivier23 @ashleypittman
DAOS-15136 client: Switch to using libfused (#14077)
fd8b5ed 
Switch to using libfused instead of libfuse3

This enables the following:

customization of libfuse for dfuse use case
Ability to release the library without breaking other fuse users.
fused is a fork of libfuse that renames
the library and header file directory.

Allow-unstable-test: true
Features: dfuse
Skip-func-hw-test: false

Change-Id: If6d2abe9dd4d02fe6b78c92c9b091cbad1838494
Signed-off-by: Jeff Olivier <[email protected]>
Co-authored-by: Ashley Pittman <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Jan 24, 2025
@jolivier23 @ashleypittman
DAOS-15136 client: Switch to using libfused (#14077)
d567d9f 
Switch to using libfused instead of libfuse3

This enables the following:

customization of libfuse for dfuse use case
Ability to release the library without breaking other fuse users.
fused is a fork of libfuse that renames
the library and header file directory.

Change-Id: If6d2abe9dd4d02fe6b78c92c9b091cbad1838494
Co-authored-by: Ashley Pittman <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Jan 25, 2025
@jolivier23 @ashleypittman
DAOS-15136 client: Switch to using libfused (#14077) (#15757)
242bdb4 
Switch to using libfused instead of libfuse3

This enables the following:

customization of libfuse for dfuse use case
Ability to release the library without breaking other fuse users.
fused is a fork of libfuse that renames
the library and header file directory.

Change-Id: If6d2abe9dd4d02fe6b78c92c9b091cbad1838494

Signed-off-by: Jeff Olivier <[email protected]>
Co-authored-by: Ashley Pittman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleypittman ashleypittman ashleypittman left review comments

@ryon-jensen ryon-jensen ryon-jensen approved these changes

@wangdi1 wangdi1 wangdi1 approved these changes

@brianjmurrell brianjmurrell brianjmurrell left review comments

@mchaarawi mchaarawi mchaarawi left review comments

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jolivier23 @daosbuild1 @mchaarawi @brianjmurrell @johannlombardi @ashleypittman @ryon-jensen @wangdi1