Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15433 build: update to libfabric 1.19.1 #14018

Merged
merged 1 commit into from
Mar 21, 2024
Merged

DAOS-15433 build: update to libfabric 1.19.1 #14018

merged 1 commit into from
Mar 21, 2024

Conversation

soumagne
Copy link
Collaborator

PR-repos: libfabric@PR-76
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@soumagne
DAOS-15433 build: update to libfabric 1.19.1
f9eb066 
PR-repos: libfabric@PR-76
Required-githooks: true

Signed-off-by: Jerome Soumagne <[email protected]>
@github-actions GitHub Actions
Copy link

Ticket title is 'Update libfabric to 1.19.1'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-15433

mchaarawi
mchaarawi approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@mchaarawi mchaarawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did the ofi RPM landing complete?

@soumagne
Copy link
Collaborator Author

soumagne commented Mar 21, 2024 •
edited
Loading

did the ofi RPM landing complete?

daos-stack/libfabric#76 it's there, you (or someone else) would need to land it first.

@soumagne soumagne requested a review from jgmoore-or March 21, 2024 19:55
@soumagne soumagne requested a review from a team March 21, 2024 20:14
@frostedcmos frostedcmos merged commit c607541 into master Mar 21, 2024
49 checks passed
@frostedcmos frostedcmos deleted the soumagne/ofi_1191 branch March 21, 2024 20:45
soumagne added a commit that referenced this pull request Mar 28, 2024
@soumagne
DAOS-15433 build: update to libfabric 1.19.1 (#14018)
b32710b 
Update to libfabric 1.19.1

Signed-off-by: Jerome Soumagne <[email protected]>
mchaarawi pushed a commit that referenced this pull request Apr 3, 2024
@soumagne
DAOS-15433 build: update to libfabric 1.19.1 (#14018) (#14082)
7208711 
Update to libfabric 1.19.1

Signed-off-by: Jerome Soumagne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgmoore-or jgmoore-or jgmoore-or approved these changes

@mchaarawi mchaarawi mchaarawi approved these changes

@frostedcmos frostedcmos Awaiting requested review from frostedcmos

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumagne @mchaarawi @jgmoore-or @frostedcmos