Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14010 placement: refine for delay rebuild #13879

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Feb 27, 2024

Fix a few typo for delay rebuild.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Fix a few typo for delay rebuild.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@wangdi1 wangdi1 requested review from a team as code owners February 27, 2024 03:42
@wangdi1 wangdi1 requested a review from liuxuezhao February 27, 2024 03:42
Copy link

Ticket title is 'Maintain stable epoch for incremental reintegration'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-14010

@wangdi1 wangdi1 requested a review from gnailzenh February 27, 2024 03:42
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13879/1/execution/node/1198/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13879/2/execution/node/1173/log

@wangdi1 wangdi1 requested a review from a team March 1, 2024 21:13
@jolivier23 jolivier23 merged commit ee3d409 into master Mar 1, 2024
48 of 49 checks passed
@jolivier23 jolivier23 deleted the wangdi/daos_14010_refine branch March 1, 2024 21:14
jolivier23 pushed a commit that referenced this pull request Mar 12, 2024
Fix a few typo for delay rebuild.

Change-Id: I9db5c2de7e2773da9dd0cc631f13ebec12fbb6c0
Signed-off-by: Di Wang <[email protected]>
jolivier23 pushed a commit that referenced this pull request Apr 10, 2024
Fix a few typo for delay rebuild.

Change-Id: I9db5c2de7e2773da9dd0cc631f13ebec12fbb6c0
Signed-off-by: Di Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants