Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15056 rebuild: add rpt to the rgt list properly #13862

Merged
merged 3 commits into from
Feb 29, 2024
Merged

DAOS-15056 rebuild: add rpt to the rgt list properly #13862

merged 3 commits into from
Feb 29, 2024

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Feb 23, 2024 •
edited
Loading

Add rpt to the rgt list before yield, in case the rpt
is incorrectly created with incoming scan RPC.

Features: rebuild
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Di Wang added 2 commits February 23, 2024 04:31
DAOS-15056 rebuild: add rpt to the rgt list properly
d665256 
Add rpt to the rgt list before yield, in case the rpt
is incorrectly created with incoming scan RPC.

Features: rebuild
Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
DAOS-15056 rebuild: fix memor leak
37d72f8 
Fix memory leak found by Niu.

Features: rebuild
Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@wangdi1 wangdi1 requested review from a team as code owners February 23, 2024 04:32
@wangdi1 wangdi1 requested review from NiuYawei and liw and removed request for a team February 23, 2024 04:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited
Loading

Ticket title is 'Functional on EL 8.8/rebuild/with_io.py/ pool destroy timeout'
Status is 'In Progress'
Labels: 'scrubbed,triaged'
https://daosio.atlassian.net/browse/DAOS-15056

@wangdi1 wangdi1 requested a review from liuxuezhao February 23, 2024 04:32
DAOS-15056 rebuild: fix typo
52bf862 
address review from wangshilong

Features: rebuild
Required-githooks: true
Signed-off-by: Di Wang <[email protected]>
@wangdi1 wangdi1 requested a review from wangshilong February 23, 2024 04:34
@wangdi1 wangdi1 changed the title Wangdi/daos 15056 DAOS-15056 rebuild: add rpt to the rgt list properly Feb 23, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13862/2/execution/node/1541/log

@wangdi1
Copy link
Contributor Author

wangdi1 commented Feb 26, 2024

failure due to DAOS-15135. @daos-stack/daos-gatekeeper please check.

@wangdi1 wangdi1 requested a review from a team February 26, 2024 17:51
@jolivier23 jolivier23 merged commit e315e7e into master Feb 29, 2024
48 of 51 checks passed
@jolivier23 jolivier23 deleted the wangdi/daos_15056 branch February 29, 2024 21:31
jolivier23 pushed a commit that referenced this pull request Jul 2, 2024
@liuxuezhao @jolivier23
b/349170185 Backport fixes
6087823 
DAOS-16039 object: fix EC aggregation wrong peer address (#14593)
DAOS-16009 rebuild: fix O_TRUNC file size related handling
DAOS-15056 rebuild: add rpt to the rgt list properly (#13862)
DAOS-15517 rebuild: refine lock handling for rpt list (#14064)
DAOS-13812 container: fix destroy vs lookup (#12757)
DAOS-15627 dtx: redunce stack usage for DTX resync to avoid overflow (#14189)
DAOS-14845 rebuild: do not wait for EC agg for reclaim (#13610)

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Mohamad Chaarawi <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Wang, Di <[email protected]>
Signed-off-by: Di Wang <[email protected]>
Signed-off-by: Wang Shilong <[email protected]>
Signed-off-by: Fan Yong <[email protected]>
@jolivier23 jolivier23 mentioned this pull request Jul 2, 2024
Merged
18 tasks
jolivier23 added a commit that referenced this pull request Jul 3, 2024
@jolivier23
b/349170185 Backport fixes (#14680)
5b9557b 
DAOS-16039 object: fix EC aggregation wrong peer address (#14593)
DAOS-16009 rebuild: fix O_TRUNC file size related handling
DAOS-15056 rebuild: add rpt to the rgt list properly (#13862)
DAOS-15517 rebuild: refine lock handling for rpt list (#14064)
DAOS-13812 container: fix destroy vs lookup (#12757)
DAOS-15627 dtx: redunce stack usage for DTX resync to avoid overflow (#14189)
DAOS-14845 rebuild: do not wait for EC agg for reclaim (#13610)

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Mohamad Chaarawi <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Wang, Di <[email protected]>
Signed-off-by: Di Wang <[email protected]>
Signed-off-by: Wang Shilong <[email protected]>
Signed-off-by: Fan Yong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@wangshilong wangshilong wangshilong approved these changes

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@liw liw Awaiting requested review from liw

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wangdi1 @daosbuild1 @liuxuezhao @wangshilong @NiuYawei @jolivier23