Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14594 test: fix dfs_parallel xml generation (#13312) #13653

Merged
merged 2 commits into from
Jan 29, 2024
Merged

DAOS-14594 test: fix dfs_parallel xml generation (#13312) #13653

merged 2 commits into from
Jan 29, 2024

Conversation

daltonbohning
Copy link
Contributor

Features: daos_core_test_dfs

Since cmocka is not MPI-aware, force all ranks other than rank 0 to write to stdout to avoid race conditions with the XML file.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 23, 2024
@daltonbohning daltonbohning self-assigned this Jan 23, 2024
daosbuild1
daosbuild1 reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13653/1/execution/node/345/log

daosbuild1
daosbuild1 reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13653/2/execution/node/341/log

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'daos_test/dfs.py:DaosCoreTestDfs.test_daos_dfs_parallel - Poorly formed xml file'
Status is 'Awaiting backport'
Labels: 'ci_impact,pr_test,tcp_provider,triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14594

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 23, 2024
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13653/2/execution/node/366/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13653/2/execution/node/367/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13653/2/execution/node/457/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13653/2/execution/node/334/log

@daltonbohning
DAOS-14594 test: fix dfs_parallel xml generation (#13312)
f73766e 
Features: daos_core_test_dfs

Since cmocka is not MPI-aware, force all ranks other than rank 0 to write to stdout to avoid race conditions with the XML file.

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning
daltonbohning commented Jan 23, 2024
View reviewed changes
src/tests/suite/dfs_test.c
/** if writing XML, force all ranks other than rank 0 to use stdout to avoid conflicts */
cmocka_message_output = getenv("CMOCKA_MESSAGE_OUTPUT");
if (rank != 0 && cmocka_message_output && strcasecmp(cmocka_message_output, "xml") == 0) {
rc = setenv("CMOCKA_MESSAGE_OUTPUT", "stdout", 1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclean because master has d_setenv but 2.4 does not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knard-intel is there a plan to port that change on 2.4? if so, we probably need to fix this later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I know, it is not planned to backport the PRs related to the ticket DAOS-14532

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I don't think we need to backport DAOS-14532

@daltonbohning daltonbohning added unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. and removed clean-cherry-pick Cherry-pick from another branch that did not require additional edits labels Jan 23, 2024
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13653/3/execution/node/155/log

@daltonbohning daltonbohning marked this pull request as ready for review January 25, 2024 00:43
@daltonbohning
Merge remote-tracking branch 'origin/release/2.4' into dbohning/daos-…
56b86c9 
…14594

Features: daos_core_test_dfs

Required-githooks: true
daosbuild1
daosbuild1 reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13653/6/testReport/

@phender
Copy link
Contributor

phender commented Jan 29, 2024

The https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13653/6/testReport/FTEST_daos_test/DaosCoreTest-DAOS_Rebuild_Simple/Test_Hardware___Functional_Hardware_Medium_Verbs_Provider___REBUILD23__object_corrupt_rebuild/ failure looks like https://daosio.atlassian.net/browse/DAOS-7378

@daltonbohning daltonbohning requested a review from a team January 29, 2024 19:28
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 29, 2024
@phender phender merged commit 2ad7164 into release/2.4 Jan 29, 2024
34 of 36 checks passed
@phender phender deleted the dbohning/daos-14594 branch January 29, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mchaarawi mchaarawi mchaarawi approved these changes

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @phender @mchaarawi @knard38