Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14654 test: simplify ior_per_rank.py (#13346) #13650

Merged
merged 2 commits into from
Jan 24, 2024
Merged

DAOS-14654 test: simplify ior_per_rank.py (#13346) #13650

merged 2 commits into from
Jan 24, 2024

Conversation

daltonbohning
Copy link
Contributor

  • Only run with transfer size 1M
  • Reduce stonewall to 15s

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-14654 test: simplify ior_per_rank.py (#13346)
3033979 
- Only run with transfer size 1M
- Reduce stonewall to 15s

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 23, 2024
@daltonbohning
DAOS-13078 test: trigger test
a2752ef 
Test-tag: test_ior_per_rank
Test-repeat: 2
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'ftest: simplify ior_per_rank.py'
Status is 'Awaiting backport'
Labels: 'tds'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14654

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 23, 2024
daosbuild1
daosbuild1 reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13650/2/testReport/

@daltonbohning daltonbohning marked this pull request as ready for review January 24, 2024 17:16
@daltonbohning daltonbohning requested a review from a team as a code owner January 24, 2024 17:16
@daltonbohning daltonbohning requested a review from a team January 24, 2024 17:16
@phender phender merged commit 50720aa into release/2.4 Jan 24, 2024
26 of 28 checks passed
@phender phender deleted the dbohning/daos-14654-2.4 branch January 24, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@phender phender phender approved these changes

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @daosbuild1 @phender