Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14824 dfuse: Allow parallel readdir calls. #13606

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

ashleypittman
Copy link
Contributor

Remove the inode lock preventing parallel readdir calls.
Update readdir caching to be thread safe.
Required-githooks: true

Signed-off-by: Ashley Pittman [email protected]

Remove the inode lock preventing parallel readdir calls.
Update readdir caching to be thread safe.
Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
Copy link

github-actions bot commented Jan 15, 2024

Bug-tracker data:
Ticket title is 'Parallel readdir in dfuse.'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-14824

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13606/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13606/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13606/2/execution/node/1475/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13606/2/testReport/

Features: dfuse

Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman ashleypittman marked this pull request as ready for review January 18, 2024 09:49
@ashleypittman ashleypittman requested a review from a team as a code owner January 18, 2024 09:49
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13606/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13606/6/execution/node/1481/log

@ashleypittman
Copy link
Contributor Author

This ran and passed all the testing but that's mostly pointless as due to a libfuse bug then the kernel feature isn't enabled in our testing.

I'm separately working on a test for this which shows significant performance improvement locally but again that won't show any change in performance or exercise this new code until we can get a new libfuse in CI so it should not block this (although I can see that the libfuse update itself might).

Features: dfuse
Required-githooks: true
@ashleypittman ashleypittman requested a review from a team as a code owner February 9, 2024 10:06
@ashleypittman ashleypittman requested a review from a team February 13, 2024 09:04
@ashleypittman ashleypittman merged commit 77d3e3a into master Feb 13, 2024
48 checks passed
@ashleypittman ashleypittman deleted the amd/readdir-parallel branch February 13, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants