Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14903 object: fix bug in agg peer status check #13585

Merged
merged 3 commits into from
Jan 23, 2024
Merged

DAOS-14903 object: fix bug in agg peer status check #13585

merged 3 commits into from
Jan 23, 2024

Conversation

liuxuezhao
Copy link
Contributor

Possibly one target failed but the rank is fine that should not affect other good targets.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2024 •
edited
Loading

Bug-tracker data:
Ticket title is 'fix bug in EC aggregation's peer update'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-14903

@liuxuezhao liuxuezhao changed the title DAOS-14903 object: fix bug in peer status check DAOS-14903 object: fix bug in agg peer status check Jan 10, 2024
@liuxuezhao liuxuezhao requested a review from wangdi1 January 10, 2024 06:54
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/1/execution/node/364/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/1/execution/node/354/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/1/execution/node/307/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/1/execution/node/308/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/1/execution/node/362/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/1/execution/node/358/log

@liuxuezhao
DAOS-14903 object: fix bug in peer status check
dc1886d 
Possibly one target failed but the rank is fine that should not affect
other good targets.

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13585/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/2/execution/node/1434/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13585/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/3/execution/node/1569/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13585/4/execution/node/1383/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13585/4/testReport/

@liuxuezhao
Copy link
Contributor Author

test failures due to https://daosio.atlassian.net/browse/DAOS-14884 and https://daosio.atlassian.net/browse/DAOS-14845#icft=DAOS-14845

@liuxuezhao liuxuezhao requested a review from a team January 21, 2024 14:28
@mchaarawi
Copy link
Contributor

I did a merge with master for you because of the fixed failing tests. please add gatekeeper after tests pass and complete. thx

@mchaarawi mchaarawi removed the request for review from a team January 22, 2024 15:55
@liuxuezhao liuxuezhao requested a review from a team January 23, 2024 01:55
@liuxuezhao
Copy link
Contributor Author

I did a merge with master for you because of the fixed failing tests. please add gatekeeper after tests pass and complete. thx

ok, all tests passed.

@mchaarawi mchaarawi merged commit d30e842 into master Jan 23, 2024
47 of 48 checks passed
@mchaarawi mchaarawi deleted the lxz/peer_check_fix branch January 23, 2024 13:35
liuxuezhao added a commit that referenced this pull request Jan 29, 2024
@liuxuezhao
DAOS-14903 container: refine task process in pmap_refresh_cb (#13491)
890a562 
should register completion callback before task reinit, or the complete
cb possibly cannot be triggered.

and a few other backports:
6d4e549 - DAOS-14788 pool: Fix some reinit usages (#13518)
91b93c8 - DAOS-13252 tests: set svcn for multiple_failure test (#13619)
d30e842 - DAOS-14903 object: fix bug in peer status check (#13585)

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Li Wei <[email protected]>
@liuxuezhao liuxuezhao mentioned this pull request Jan 29, 2024
Merged
18 tasks
liuxuezhao added a commit that referenced this pull request Jan 30, 2024
@liuxuezhao
DAOS-14903 container: refine task process in pmap_refresh_cb (#13491)
1d6011d 
should register completion callback before task reinit, or the complete
cb possibly cannot be triggered.

and a few other backports:
6d4e549 - DAOS-14788 pool: Fix some reinit usages (#13518)
91b93c8 - DAOS-13252 tests: set svcn for multiple_failure test (#13619)
d30e842 - DAOS-14903 object: fix bug in peer status check (#13585)

Required-githooks: true
Test-tag: pr ec_multiple_failure

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Li Wei <[email protected]>
daltonbohning pushed a commit that referenced this pull request Feb 2, 2024
@liuxuezhao
DAOS-14903 container: refine task process in pmap_refresh_cb (#13491) (…
60bbb3a 
…#13682)

should register completion callback before task reinit, or the complete
cb possibly cannot be triggered.

and a few other backports:
6d4e549 - DAOS-14788 pool: Fix some reinit usages (#13518)
91b93c8 - DAOS-13252 tests: set svcn for multiple_failure test (#13619)
d30e842 - DAOS-14903 object: fix bug in peer status check (#13585)

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Li Wei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangdi1 wangdi1 wangdi1 approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@NiuYawei NiuYawei Awaiting requested review from NiuYawei

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuxuezhao @daosbuild1 @mchaarawi @Nasf-Fan @wangdi1