Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14194 common: fix memory leak reported by Coverity #13566

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jan 4, 2024

DAOS-14194 common: fix memory leak reported by Coverity
CID 1347807 - resource leak

Related to: #12866

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Copy link

github-actions bot commented Jan 4, 2024

Bug-tracker data:
Ticket title is '[coverity] 1347807 Resource leak'
Status is 'In Review'
Labels: '2.4.1rc1,coverity,required_for_code_freeze,scrubbed'
https://daosio.atlassian.net/browse/DAOS-14194

@grom72 grom72 force-pushed the grom72/DAOS-14194 branch from 98ab258 to 8585609 Compare January 4, 2024 13:55
@grom72 grom72 marked this pull request as ready for review January 4, 2024 14:10
@ryon-jensen ryon-jensen self-requested a review January 31, 2024 16:39
@grom72 grom72 requested a review from a team February 13, 2024 19:44
@NiuYawei NiuYawei merged commit 453c78c into master Feb 19, 2024
55 checks passed
@NiuYawei NiuYawei deleted the grom72/DAOS-14194 branch February 19, 2024 01:52
@daltonbohning
Copy link
Contributor

@daos-stack/daos-gatekeeper can we complete this PR

@grom72 It was merged 3 days ago. What do you mean by "complete"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants