Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14352 object: recover migrate with correct epoch #13547

Merged
merged 2 commits into from
Jan 5, 2024
Merged

DAOS-14352 object: recover migrate with correct epoch #13547

merged 2 commits into from
Jan 5, 2024

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Dec 30, 2023

During migration, it should choose the minimum epoch from rebuild stable epoch and EC aggregation boundary to make sure correct data is being fetched during recovery.

Add tests to verify the process.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

DAOS-14352 object: recover migrate with correct epoch
4e00773 
During migration, it should choose the minimum epoch from
rebuild stable epoch and EC aggregation boundary to make
sure correct data is being fetched during recovery.

Add tests to verify the process.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'FTEST_daos_test.DAOS_Drain_Simple.DRAIN17 - 262144 bytes of 0x562506eb84a0 and 0x562506ba02b0 differ'
Status is 'Reopened'
Labels: 'ci_impact,pr_test'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14352

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 30, 2023
liuxuezhao
liuxuezhao previously approved these changes Jan 3, 2024
View reviewed changes
src/object/srv_obj_migrate.c
@@ -1073,7 +1073,7 @@ migrate_fetch_update_parity(struct migrate_one *mrone, daos_handle_t oh,
*/
if (ds_cont->sc_ec_agg_eph_boundary >
mrone->mo_iods_update_ephs_from_parity[i][j])
fetch_eph = mrone->mo_epoch;
fetch_eph = min(ds_cont->sc_ec_agg_eph_boundary, mrone->mo_epoch);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may update the comment at following patch, thx

DAOS-14352 objects: update the comments
f0b6ff7 
update the comments.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@jolivier23 jolivier23 merged commit bf6c881 into master Jan 5, 2024
46 of 47 checks passed
@jolivier23 jolivier23 deleted the wangdi/daos_14352_overwrite branch January 5, 2024 22:59
wangdi1 pushed a commit that referenced this pull request Feb 7, 2024
DAOS-14352 object: recover migrate with correct epoch (#13547)
e91143c 
During migration, it should choose the minimum epoch from
rebuild stable epoch and EC aggregation boundary to make
sure correct data is being fetched during recovery.

Add tests to verify the process.

Signed-off-by: Di Wang <[email protected]>
jolivier23 pushed a commit that referenced this pull request Feb 28, 2024
@jolivier23
DAOS-14352 object: recover migrate with correct epoch (#13547)
12d57bf 
During migration, it should choose the minimum epoch from
rebuild stable epoch and EC aggregation boundary to make
sure correct data is being fetched during recovery.

Add tests to verify the process.

Signed-off-by: Di Wang <[email protected]>
jolivier23 pushed a commit that referenced this pull request Mar 12, 2024
@jolivier23
DAOS-14352 object: recover migrate with correct epoch (#13547)
1372e4f 
During migration, it should choose the minimum epoch from
rebuild stable epoch and EC aggregation boundary to make
sure correct data is being fetched during recovery.

Add tests to verify the process.

Signed-off-by: Di Wang <[email protected]>
jolivier23 pushed a commit that referenced this pull request Apr 10, 2024
@jolivier23
DAOS-14352 object: recover migrate with correct epoch (#13547)
613a907 
During migration, it should choose the minimum epoch from
rebuild stable epoch and EC aggregation boundary to make
sure correct data is being fetched during recovery.

Add tests to verify the process.

Signed-off-by: Di Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

Assignees
No one assigned
Labels
priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangdi1 @liuxuezhao @jolivier23