Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14592 test: Fix dmg_system_reformat engine restart detection #13454

Merged
merged 6 commits into from
Jan 5, 2024
Merged

DAOS-14592 test: Fix dmg_system_reformat engine restart detection #13454

merged 6 commits into from
Jan 5, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Dec 6, 2023

When detecting if the engines have restarted in dmg_system_reformat, use the time since the restart as opposed to the original start time.

Test-tag: test_dmg_system_reformat

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-14592 test: Fix dmg_system_reformat engine restart detection
a984ee2 
When detecting if the engines have restarted in dmg_system_reformat, use
the time since the restart as opposed to the original start time.

Test-tag: test_dmg_system_reformat

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Bug-tracker data:
Ticket title is 'control/dmg_system_reformat.py:DmgSystemReformatTest.test_dmg_system_reformat - system is uninitialized'
Status is 'In Progress'
Labels: 'ci_impact,daily_test,md_on_ssd,triaged'
https://daosio.atlassian.net/browse/DAOS-14592

daosbuild1
daosbuild1 reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@phender
Fix typo.
50dbffe 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true
Test-tag: test_dmg_system_reformat

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
daosbuild1
daosbuild1 reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@phender phender marked this pull request as ready for review January 4, 2024 15:16
@phender phender requested a review from a team as a code owner January 4, 2024 15:16
daltonbohning
daltonbohning previously approved these changes Jan 4, 2024
View reviewed changes
src/tests/ftest/util/server_utils.py Outdated
@@ -1,5 +1,5 @@
"""
(C) Copyright 2018-2023 Intel Corporation.
(C) Copyright 2018-2024 Intel Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erroneous?

@phender
Manually fix copyrights.
c3ab089 
Skip-func-hw-medium-md-on-ssd: false
Test-tag: test_dmg_system_reformat

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested a review from daltonbohning January 5, 2024 14:42
@phender phender requested a review from mjean308 January 5, 2024 16:59
@phender phender requested a review from a team January 5, 2024 17:42
@phender
Copy link
Contributor Author

phender commented Jan 5, 2024

Test is now passing: https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13454/4/testReport/FTEST_control/DmgSystemReformatTest/

@daltonbohning daltonbohning merged commit dd69955 into master Jan 5, 2024
44 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-14592 branch January 5, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mjean308 mjean308 mjean308 approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phender @daltonbohning @daosbuild1 @mjean308