Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14568 control: dmg pool query info change targets to ranks #13298

Merged
merged 2 commits into from
Nov 16, 2023
Merged

DAOS-14568 control: dmg pool query info change targets to ranks #13298

merged 2 commits into from
Nov 16, 2023

Conversation

knard38
Copy link
Contributor

@knard38 knard38 commented Nov 6, 2023 •
edited
Loading

Description

dmg pool query -e: reports ranks as targets

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Bug-tracker data:
Ticket title is 'dmg pool query -e: reports ranks as targets'
Status is 'In Progress'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-14568

daosbuild1
daosbuild1 reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@knard38 knard38 mentioned this pull request Nov 6, 2023
Closed
@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13298/1/testReport/

@knard38 knard38 force-pushed the yyyshi/fix/master/daos-14568 branch from da9fa14 to e2576d4 Compare November 7, 2023 07:46
daosbuild1
daosbuild1 reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

yyyshi and others added 2 commits November 7, 2023 20:44
@yyyshi
DAOS-14568 control: dmg pool query info change targets to ranks
7ed7158 
Required-githooks: true
Signed-off-by: shiying <[email protected]>
@kanard38
DAOS-14568 control: dmg pool query info change targets to ranks
510f857 
Fix golang unit test.

Required-githooks: true
Signed-off-by: Cedric Koch-Hofer <[email protected]>
@knard38 knard38 force-pushed the yyyshi/fix/master/daos-14568 branch from e2576d4 to 510f857 Compare November 7, 2023 20:44
daosbuild1
daosbuild1 reviewed Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@knard38 knard38 marked this pull request as ready for review November 13, 2023 09:31
@knard38 knard38 requested review from a team as code owners November 13, 2023 09:31
@knard38 knard38 requested a review from a team November 15, 2023 06:44
@knard38
Copy link
Contributor Author

knard38 commented Nov 15, 2023

@daos-stack/daos-gatekeeper could you please, land this ticket with the following message:

DAOS-14568 control: dmg pool query info change targets to ranks

Fix invalid dmg pool query output.

Signed-off-by: shiying <[email protected]>
Signed-off-by: Cedric Koch-Hofer <[email protected]>

@NiuYawei NiuYawei merged commit d89bb20 into master Nov 16, 2023
@NiuYawei NiuYawei deleted the yyyshi/fix/master/daos-14568 branch November 16, 2023 11:43
yyyshi pushed a commit to yyyshi/daos that referenced this pull request Nov 22, 2023
@knard38 @yyyshi
DAOS-14568 control: dmg pool query info change targets to ranks (daos…
c42ef39 
…-stack#13298)

DAOS-14568 control: dmg pool query info change targets to ranks

Fix invalid dmg pool query output.

Signed-off-by: shiying <[email protected]>
Signed-off-by: Cedric Koch-Hofer <[email protected]>
Signed-off-by: shiying <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@kjacque kjacque kjacque approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac Awaiting requested review from mjmac

@Michael-Hennecke Michael-Hennecke Awaiting requested review from Michael-Hennecke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@knard38 @daosbuild1 @tanabarr @kjacque @NiuYawei @yyyshi @kanard38