Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14181 control: Remove bdev scan cache #13256

Closed
wants to merge 19 commits into from
Closed

DAOS-14181 control: Remove bdev scan cache #13256

wants to merge 19 commits into from

Conversation

tanabarr
Copy link
Contributor

Introduce direct scanning of NVMe devices through dRPC. With this new
interface, when an engine-owned SSD is hotplugged (replaced) details
of the new physical device will be available through dmg storage scan.

Changes applied:

  • Remove bdev scan cache used to store static controller details.
  • Respect functional boundaries better in unit tests through improved
    decoupling of dependencies.
  • Implement dRPC callers and handlers to scan and populate nested NVMe
    structures.
  • Simplify decision-making when performing scans.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr tanabarr added control-plane work on the management infrastructure of the DAOS Control Plane go Pull requests that update Go code labels Oct 30, 2023
@tanabarr tanabarr self-assigned this Oct 30, 2023
@github-actions
Copy link

Bug-tracker data:
Ticket title is 'Remove bdev scan cache'
Status is 'In Progress'
Labels: 'SPDK,drpc'
https://daosio.atlassian.net/browse/DAOS-14181

daosbuild1
daosbuild1 reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@tanabarr tanabarr force-pushed the tanabarr/control-remove-bdev-scan-cache branch from d8484d6 to f2ae965 Compare October 30, 2023 18:05
@tanabarr tanabarr requested review from mjmac, kjacque and knard38 October 30, 2023 18:07
daosbuild1
daosbuild1 reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@tanabarr
Copy link
Contributor Author

Wanted to get some early reviews on this change as it is significant. Basically "ripping the Band-Aid off" and "breaking some eggs to make an omelette" come to mind with this. Specifically @knard-intel I've gutted a lot of the previous bdev scan logic and I'm trying to simplify the flow in the redesign, as a result I have removed some of the space-adjustment code that you have implemented and I will retrospectively add that back in after I get the basics working. Any feedback appreciated.

@tanabarr
Copy link
Contributor Author

I will be adding engine side code in a separate Commit.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/2/execution/node/1280/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13256/2/testReport/

daosbuild1
daosbuild1 previously requested changes Nov 3, 2023
View reviewed changes
src/control/server/ctl_smd_rpc_test.go Outdated
TrAddr: "0000:8a:00.0",
TgtIds: []int32{0, 1, 2},
Devices: []*ctlpb.SmdDevice{
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
Uuid: test.MockUUID(1),
TrAddr: "0000:80:00.0",
TgtIds: []int32{3, 4, 5},
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
TrAddr: "0000:da:00.0",
TgtIds: []int32{0, 1, 2},
Devices: []*ctlpb.SmdDevice{
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
Uuid: test.MockUUID(3),
TrAddr: "0000:db:00.0",
TgtIds: []int32{3, 4, 5},
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
TrAddr: "0000:8a:00.0",
TgtIds: []int32{0, 1, 2},
Devices: []*ctlpb.SmdDevice{
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/3/execution/node/149/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/3/execution/node/337/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/3/execution/node/408/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/3/execution/node/402/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/3/execution/node/401/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/3/execution/node/326/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/3/execution/node/340/log

@daosbuild1 daosbuild1 dismissed their stale review November 3, 2023 23:46

Updated patch

daosbuild1
daosbuild1 previously requested changes Nov 3, 2023
View reviewed changes
src/control/server/ctl_smd_rpc_test.go Outdated
TrAddr: "0000:8a:00.0",
TgtIds: []int32{0, 1, 2},
Devices: []*ctlpb.SmdDevice{
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
Uuid: test.MockUUID(1),
TrAddr: "0000:80:00.0",
TgtIds: []int32{3, 4, 5},
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
TrAddr: "0000:da:00.0",
TgtIds: []int32{0, 1, 2},
Devices: []*ctlpb.SmdDevice{
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
Uuid: test.MockUUID(3),
TrAddr: "0000:db:00.0",
TgtIds: []int32{3, 4, 5},
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

src/control/server/ctl_smd_rpc_test.go Outdated
TrAddr: "0000:8a:00.0",
TgtIds: []int32{0, 1, 2},
Devices: []*ctlpb.SmdDevice{
&ctlpb.SmdDevice{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&ctlpb.SmdDevice{
{

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/4/execution/node/149/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13256/4/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/4/execution/node/1285/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/4/execution/node/1423/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/4/execution/node/1407/log

@tanabarr tanabarr force-pushed the tanabarr/control-remove-bdev-scan-cache branch from 814a2eb to ce7abe5 Compare November 8, 2023 18:07
@tanabarr
improve json parsing of bdev params with spdk api pt2
23311fe 
Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/20/execution/node/582/log

daosbuild1
daosbuild1 reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/21/execution/node/582/log

@tanabarr
add namespace info to proto response
4ee62f9 
Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr force-pushed the tanabarr/control-remove-bdev-scan-cache branch from fc2381f to 4ee62f9 Compare November 21, 2023 17:47
daosbuild1
daosbuild1 reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/22/execution/node/408/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/22/execution/node/360/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/22/execution/node/395/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/22/execution/node/396/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/22/execution/node/313/log

@tanabarr tanabarr requested a review from kjacque November 21, 2023 23:52
daosbuild1
daosbuild1 reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/23/execution/node/582/log

daosbuild1
daosbuild1 reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/24/execution/node/581/log

@tanabarr
revert unnecessary changes to fill_in_traddr
a435cf5 
Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/25/execution/node/386/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/25/execution/node/404/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/25/execution/node/425/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/25/execution/node/360/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13256/25/execution/node/390/log

@tanabarr
Copy link
Contributor Author

replaced by #13382 and a follow-on PR

@tanabarr tanabarr closed this Nov 25, 2023
@tanabarr tanabarr deleted the tanabarr/control-remove-bdev-scan-cache branch November 25, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mjmac mjmac Awaiting requested review from mjmac

@knard38 knard38 Awaiting requested review from knard38

@kjacque kjacque Awaiting requested review from kjacque

Assignees

@tanabarr tanabarr

Labels
control-plane work on the management infrastructure of the DAOS Control Plane go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanabarr @daosbuild1 @kjacque