Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14561 vos: Add garbage collection metrics #13244

Merged
merged 1 commit into from
Oct 30, 2023
Merged

DAOS-14561 vos: Add garbage collection metrics #13244

merged 1 commit into from
Oct 30, 2023

Conversation

jolivier23
Copy link
Contributor

  • Add some metrics for garbage collection
  • Add total metrics for vos space, so we can infer free space

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jolivier23 jolivier23 requested a review from a team as a code owner October 26, 2023 22:47
daosbuild1
daosbuild1 reviewed Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'add garbage collection metrics'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-14561

daosbuild1
daosbuild1 reviewed Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 requested a review from mjmac October 26, 2023 22:54
@jolivier23
DAOS-14561 vos: Add garbage collection metrics
f4be31b 
* Add some metrics for garbage collection
* Add total metrics for vos space, so we can infer free space

Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
daosbuild1
daosbuild1 reviewed Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 requested review from janekmi and wangdi1 October 27, 2023 15:08
@NiuYawei NiuYawei requested a review from a team October 30, 2023 01:22
@NiuYawei NiuYawei merged commit 1c1d8d9 into master Oct 30, 2023
13 of 15 checks passed
@NiuYawei NiuYawei deleted the jvolivie/metrics branch October 30, 2023 01:23
mjmac pushed a commit that referenced this pull request Nov 8, 2023
@jolivier23 @mjmac
DAOS-14561 vos: Add garbage collection metrics (#13244)
5c0a04b 
* Add some metrics for garbage collection
* Add total metrics for vos space, so we can infer free space

Signed-off-by: Jeff Olivier <[email protected]>
mjmac added a commit that referenced this pull request Nov 21, 2023
@jolivier23 @mjmac
DAOS-14561 vos: Add garbage collection metrics (#13244)
79d5230 
* Add some metrics for garbage collection
* Add total metrics for vos space, so we can infer free space
* Add aggregation failure counter

Also adds a small change to the Go builder for
handling versions with a -suffix.

Co-authored-by: Michael MacDonald <[email protected]>
Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Michael MacDonald <[email protected]>
yyyshi pushed a commit to yyyshi/daos that referenced this pull request Nov 22, 2023
@jolivier23 @yyyshi
DAOS-14561 vos: Add garbage collection metrics (daos-stack#13244)
ad0136e 
* Add some metrics for garbage collection
* Add total metrics for vos space, so we can infer free space

Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: shiying <[email protected]>
mjmac added a commit that referenced this pull request Jan 2, 2024
@jolivier23 @mjmac
DAOS-14561 vos: Add garbage collection metrics (#13244)
aa7d66b 
* Add some metrics for garbage collection
* Add total metrics for vos space, so we can infer free space
* Add aggregation failure counter

Also adds a small change to the Go builder for
handling versions with a -suffix.

Required-githooks: true
Change-Id: I098ec9ddce846758f669fd8d7dba7a0a5b44ef2d

Co-authored-by: Michael MacDonald <[email protected]>
Change-Id: I97502b0503fbe0b5bc57d7b3cee514264b885fa3
Signed-off-by: Jeff Olivier <[email protected]>
Signed-off-by: Michael MacDonald <[email protected]>
@mjmac mjmac mentioned this pull request Jan 2, 2024
Closed
jolivier23 added a commit that referenced this pull request Jan 31, 2024
@mjmac @jolivier23
DAOS-14561 vos: Add garbage collection metrics (#13244) (#13369)
56a186f 
* Add some metrics for garbage collection
* Add total metrics for vos space, so we can infer free space
* Add aggregation failure counter

Also adds a small change to the Go builder for
handling versions with a -suffix.

Signed-off-by: Michael MacDonald <[email protected]>
Co-authored-by: Jeff Olivier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@wangdi1 wangdi1 wangdi1 approved these changes

@NiuYawei NiuYawei NiuYawei approved these changes

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

@mjmac mjmac Awaiting requested review from mjmac

@janekmi janekmi Awaiting requested review from janekmi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolivier23 @NiuYawei @wangdi1 @daosbuild1