Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14410 common: update PMDK to version 2.0.0 #13217

Merged
merged 8 commits into from
Nov 29, 2023
Merged

DAOS-14410 common: update PMDK to version 2.0.0 #13217

merged 8 commits into from
Nov 29, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Oct 20, 2023 •
edited
Loading

Update DAOS to use the latest stable version of PMDK (2.0.0)
* Remove libpmemblk from dependencies.
* Start using BUILD_EXAMPLES=n and BUILD_BENCHMARKS=n instead of patches.
* Stop using BUILD_RPMEMM=n and NDCTL_DISABLE=y.
* Point https://github.com/pmem/pmdk as the main PMDK reference source.
NOTE: PMDK upgrade to 2.0.0 does not affect any API call used by DAOS.
libpmemobj (and libpmem) API stays unchanged.

Remove irrelevant libpmem.h include.

Signed-off-by: Tomasz Gromadzki [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@grom72
DAOS-14410 common: update PMDK to version 2.0.0
a5ea167 
Update DAOS to use the latest stable version of PMDK.
Remove irrelevant libpmem.h include.

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 requested review from janekmi and osalyk October 20, 2023 17:22
@grom72 grom72 requested review from a team as code owners October 20, 2023 17:22
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'Upgrade DAOS to the latest version of PMDK (2.0.0)'
Status is 'In Review'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-14410

daosbuild1
daosbuild1 reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

jolivier23
jolivier23 previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a double take here because 2.0 would mean breaking compatibility but it's breaking everything outside of libpmemobj

@grom72
Extend documentation
38058f6 
Signed-off-by: Tomasz Gromadzki <[email protected]>
daosbuild1
daosbuild1 reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

brianjmurrell
brianjmurrell requested changes Oct 23, 2023
View reviewed changes
third_party_programs.txt Outdated Show resolved Hide resolved
utils/rpms/daos.spec Show resolved Hide resolved
daosbuild1
daosbuild1 reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@grom72 grom72 requested a review from brianjmurrell October 23, 2023 16:05
brianjmurrell
brianjmurrell previously approved these changes Oct 23, 2023
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13217/3/execution/node/1326/log

janekmi
janekmi requested changes Nov 17, 2023
View reviewed changes
debian/changelog Outdated Show resolved Hide resolved
utils/rpms/daos.spec Outdated Show resolved Hide resolved
utils/rpms/daos.spec Outdated Show resolved Hide resolved
@grom72
Minor documentation improvements
7f03d59 
Signed-off-by: Tomasz Gromadzki <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13217/4/execution/node/584/log

janekmi
janekmi previously approved these changes Nov 17, 2023
View reviewed changes
@grom72
merge with the latest master branch
81baecc 
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
missing line added
a621f73 
Signed-off-by: Tomasz Gromadzki <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@grom72 grom72 requested a review from janekmi November 17, 2023 15:33
janekmi
janekmi previously approved these changes Nov 17, 2023
View reviewed changes
brianjmurrell
brianjmurrell previously approved these changes Nov 20, 2023
View reviewed changes
@grom72
merge with the latest master branch
6f7400d 
Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 dismissed stale reviews from brianjmurrell and janekmi via 6f7400d November 21, 2023 06:27
@grom72 grom72 requested a review from janekmi November 21, 2023 06:28
daosbuild1
daosbuild1 reviewed Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ryon-jensen ryon-jensen requested a review from a team November 28, 2023 20:17
@daltonbohning daltonbohning merged commit c27c3d8 into master Nov 29, 2023
47 checks passed
@daltonbohning daltonbohning deleted the grom72/pmdk-2.0.0 branch November 29, 2023 22:30
kccain pushed a commit that referenced this pull request Nov 29, 2023
@grom72 @kccain
DAOS-14410 common: update PMDK to version 2.0.0 (#13217)
f53d653 
Update DAOS to use the latest stable version of PMDK.
Remove irrelevant libpmem.h include.

Signed-off-by: Tomasz Gromadzki <[email protected]>
Signed-off-by: Kenneth Cain <[email protected]>
grom72 added a commit that referenced this pull request Dec 6, 2023
@grom72
DAOS-14410 common: update PMDK to version 2.0.0 (#13217)
8c1fc55 
Update DAOS to use the latest stable version of PMDK.
Remove irrelevant libpmem.h include.

Required-githooks: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@osalyk osalyk osalyk approved these changes

@janekmi janekmi janekmi approved these changes

@brianjmurrell brianjmurrell brianjmurrell approved these changes

@jolivier23 jolivier23 jolivier23 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grom72 @daosbuild1 @brianjmurrell @janekmi @jolivier23 @osalyk @daltonbohning