Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14534 test: Fix bandit issues in CR demo scripts #13211

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

shimizukko
Copy link
Contributor

Following bandit issue was reported in feature/cat_recovery branch:

Test ID: B404 Severity: LOW Confidence: HIGH
CWE: CWE-78 (https://cwe.mitre.org/data/definitions/78.html)
Consider possible security implications associated with the subprocess module.
Location ./utils/cr_demo/demo_utils.py:6

+2 other files. They all need nosec at the end of the line to exclude these lines from the bandit check because we treat import subprocess as not an issue.

Skip-test: true
Skip-unit-tests: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Following bandit issue was reported in feature/cat_recovery branch:

Test ID: B404 Severity: LOW Confidence: HIGH
CWE: CWE-78 (https://cwe.mitre.org/data/definitions/78.html)
Consider possible security implications associated with the subprocess module.
Location ./utils/cr_demo/demo_utils.py:6

+2 other files. They all need nosec at the end of the line to exclude
these lines from the bandit check because we treat import subprocess
as not an issue.

Skip-test: true
Skip-unit-tests: true
Signed-off-by: Makito Kano <[email protected]>
@github-actions
Copy link

Bug-tracker data:
Ticket title is 'Fix bandit issues in CR demo scripts'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-14534

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13211/1/execution/node/148/log

Skip-test: true
Skip-unit-tests: true
Signed-off-by: Makito Kano <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Skip-test: true
Skip-unit-tests: true
Required-githooks: true
Signed-off-by: Makito Kano <[email protected]>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@shimizukko shimizukko marked this pull request as ready for review October 20, 2023 05:31
@shimizukko shimizukko requested a review from a team October 24, 2023 04:25
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 24, 2023
@daltonbohning daltonbohning merged commit 20d0d04 into feature/cat_recovery Oct 24, 2023
13 of 15 checks passed
@daltonbohning daltonbohning deleted the makito/DAOS-14534 branch October 24, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants