-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-14534 test: Fix bandit issues in CR demo scripts #13211
Conversation
Following bandit issue was reported in feature/cat_recovery branch: Test ID: B404 Severity: LOW Confidence: HIGH CWE: CWE-78 (https://cwe.mitre.org/data/definitions/78.html) Consider possible security implications associated with the subprocess module. Location ./utils/cr_demo/demo_utils.py:6 +2 other files. They all need nosec at the end of the line to exclude these lines from the bandit check because we treat import subprocess as not an issue. Skip-test: true Skip-unit-tests: true Signed-off-by: Makito Kano <[email protected]>
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13211/1/execution/node/148/log |
Skip-test: true Skip-unit-tests: true Signed-off-by: Makito Kano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Skip-test: true Skip-unit-tests: true Required-githooks: true Signed-off-by: Makito Kano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Following bandit issue was reported in feature/cat_recovery branch:
+2 other files. They all need nosec at the end of the line to exclude these lines from the bandit check because we treat import subprocess as not an issue.
Skip-test: true
Skip-unit-tests: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: