Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14467 chk: properly stop check scheduler #13181

Merged
merged 1 commit into from
Nov 23, 2023
Merged

DAOS-14467 chk: properly stop check scheduler #13181

merged 1 commit into from
Nov 23, 2023

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Oct 15, 2023 •
edited
Loading

When someone wants to stop current check instance, it needs to set ins->ci_sched_exiting to notify related instance scheduler to exit.

Originally, we used "ci_sched_running" for such purpose. But it is confused to distinguish whether the scheduler has already exited or someone is stopping the instance. The others may misunderstand that related check scheduler has already exited, but the scheduler is in stopping process, as to subsequent checker restart will get failure.

Some code cleanup.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions
Copy link

github-actions bot commented Oct 15, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'feature/cat_recovery: Intermittent daos_test CR test failures'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-14467

daosbuild1
daosbuild1 reviewed Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/1/execution/node/147/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch from c61f30d to bc871f1 Compare October 15, 2023 14:38
@Nasf-Fan Nasf-Fan changed the title DAOS-14467 chk: properly stop check instance DAOS-14467 chk: properly stop check scheduler Oct 15, 2023
daosbuild1
daosbuild1 reviewed Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/2/execution/node/148/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch from bc871f1 to 2e93b64 Compare October 19, 2023 05:59
daosbuild1
daosbuild1 reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/3/execution/node/147/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch from 2e93b64 to 550de9a Compare October 25, 2023 08:57
daosbuild1
daosbuild1 reviewed Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/4/execution/node/387/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/4/execution/node/408/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/4/execution/node/393/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/4/execution/node/353/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/4/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/4/execution/node/392/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch from 550de9a to e989308 Compare November 5, 2023 11:02
daosbuild1
daosbuild1 reviewed Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/5/execution/node/1388/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch 3 times, most recently from 9b69e2e to 2b6b53f Compare November 9, 2023 17:21
daosbuild1
daosbuild1 reviewed Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/6/execution/node/1388/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch from 2b6b53f to ae17b92 Compare November 11, 2023 09:07
daosbuild1
daosbuild1 reviewed Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/7/execution/node/1363/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch from ae17b92 to 36bfcdb Compare November 15, 2023 02:25
@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/12/execution/node/406/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/12/execution/node/396/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/12/execution/node/355/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/12/execution/node/321/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/12/execution/node/313/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/13/execution/node/304/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/13/execution/node/266/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/13/execution/node/263/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/13/execution/node/259/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13181/13/execution/node/308/log

@Nasf-Fan
DAOS-14467 chk: properly stop check scheduler
e945d45 
When someone wants to stop current check instance, it needs to set
ins->ci_sched_exiting to notify related instance scheduler to exit.

Originally, we used "ci_sched_running" for such purpose. But it is
confused to distinguish whether the scheduler has already exited or
someone is stopping the instance. The others may misunderstand that
related check scheduler has already exited, but the scheduler is in
stopping process, as to subsequent checker restart will get failure.

Some code cleanup.

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-14467 branch from 4d6a902 to e945d45 Compare November 17, 2023 02:26
daosbuild1
daosbuild1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review November 19, 2023 01:33
@Nasf-Fan Nasf-Fan requested review from a team as code owners November 19, 2023 01:33
@Nasf-Fan Nasf-Fan requested review from a team and removed request for a team November 20, 2023 02:04
daltonbohning
daltonbohning reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

src/tests/ftest/daos_test/suite.yaml
@@ -9,7 +9,7 @@ timeout: 600
timeouts:
test_daos_degraded_mode: 450
test_daos_management: 110
test_daos_cat_recovery: 1800
test_daos_cat_recovery: 3000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pointing out this adds 20 minutes to the timeout, for a total of 50 minutes. And being a pr test, this really slows down CI.
It's not a comment for just this test, but more so the general trend of having too many long-running pr tests.

Copy link
Contributor Author

@Nasf-Fan Nasf-Fan Nov 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The long time for test is mainly because frequently system start/stop in every test case. So maybe remove it from pr tests? If necessary, it can be done in next patch, another two patches depends on this one.

In fact, the test is not always so slow, instead, randomly. Mainly because the slow process for "dmg system start/stop", that is out of current patch control.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please, otherwise it's going to be problematic.

@Nasf-Fan Nasf-Fan requested a review from a team November 21, 2023 02:55
gnailzenh
gnailzenh approved these changes Nov 22, 2023
View reviewed changes
src/tests/ftest/daos_test/suite.yaml
@@ -9,7 +9,7 @@ timeout: 600
timeouts:
test_daos_degraded_mode: 450
test_daos_management: 110
test_daos_cat_recovery: 1800
test_daos_cat_recovery: 3000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please, otherwise it's going to be problematic.

@gnailzenh gnailzenh merged commit ca86895 into feature/cat_recovery Nov 23, 2023
26 of 27 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-14467 branch November 23, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@daltonbohning daltonbohning daltonbohning left review comments

@gnailzenh gnailzenh gnailzenh approved these changes

@shimizukko shimizukko shimizukko approved these changes

@liw liw liw approved these changes

@ryon-jensen ryon-jensen Awaiting requested review from ryon-jensen

@kjacque kjacque Awaiting requested review from kjacque

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nasf-Fan @daosbuild1 @liw @shimizukko @gnailzenh @daltonbohning