Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13047 chk: misc fixes for chk related issues - X #13024

Merged
merged 1 commit into from
Sep 25, 2023
Merged

DAOS-13047 chk: misc fixes for chk related issues - X #13024

merged 1 commit into from
Sep 25, 2023

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Sep 8, 2023 •
edited
Loading 

Mainly contains the following fixes:

1. Do not start pool service for orphan pool after check.

2. Enable CR25 to test "for-all" option for check repair.

3. CR26 and CR27 to verify how the checker can handle the case that
   some check engine failed to report some pool when start checker.

4. Some cleanup for former review feedback.

Signed-off-by: Fan Yong <[email protected]>

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Bug-tracker data:
Ticket title is 'CR unit test for DAOS distributed check engine logic'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-13047

daosbuild1
daosbuild1 reviewed Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/1/execution/node/1311/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from b77e3c7 to f83d1a1 Compare September 9, 2023 05:56
daosbuild1
daosbuild1 reviewed Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/2/execution/node/1266/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13024/2/testReport/

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from f83d1a1 to 41413db Compare September 11, 2023 16:57
daosbuild1
daosbuild1 reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan changed the title DAOS-13047 tests: enable CR25 DAOS-13047 chk: misc fixes for chk related issues - X Sep 11, 2023
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/3/execution/node/1343/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/3/execution/node/1327/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from 41413db to 0086f2a Compare September 12, 2023 16:18
daosbuild1
daosbuild1 reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13024/4/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/4/execution/node/1267/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from 0086f2a to de4dc48 Compare September 13, 2023 06:32
daosbuild1
daosbuild1 reviewed Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/5/execution/node/1314/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/5/execution/node/1298/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from de4dc48 to d866a84 Compare September 13, 2023 15:56
daosbuild1
daosbuild1 reviewed Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13024/6/display/redirect

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from d866a84 to 3e5c124 Compare September 14, 2023 04:25
daosbuild1
daosbuild1 reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from 3e5c124 to 26dbaa1 Compare September 14, 2023 05:24
daosbuild1
daosbuild1 reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/8/execution/node/392/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/8/execution/node/409/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/8/execution/node/334/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/8/execution/node/335/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13024/8/execution/node/397/log

@Nasf-Fan
DAOS-13047 chk: misc fixes for chk related issues - X
2fcf848 
Mainly contains the following fixes:

1. Do not start pool service for orphan pool after check.

2. Enable CR25 to test "for-all" option for check repair.

3. CR26 and CR27 to verify how the checker can handle the case that
   some check engine failed to report some pool when start checker.

4. Some cleanup for former review feedback.

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-13047_6 branch from 26dbaa1 to 2fcf848 Compare September 14, 2023 06:27
daosbuild1
daosbuild1 reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review September 15, 2023 00:51
liw
liw reviewed Sep 19, 2023
View reviewed changes
src/pool/srv_target.c
DP_UUID(uuid), rc);
D_GOTO(failure_pool, rc);
}
if (!engine_in_check()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] Would it make sense to comment on why we don't want to do these in the "check mode"? To be honest, I don't know the reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the CR logic will evict all former connections. I will add comment in subsequent patch.

@liw liw self-requested a review September 19, 2023 09:25
@Nasf-Fan
Copy link
Contributor Author

Ping reviewers, thanks!

@Nasf-Fan Nasf-Fan requested a review from a team September 25, 2023 01:40
@gnailzenh gnailzenh merged commit 15e54c5 into feature/cat_recovery Sep 25, 2023
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-13047_6 branch September 25, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@gnailzenh gnailzenh gnailzenh approved these changes

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@liw liw liw approved these changes

@ryon-jensen ryon-jensen Awaiting requested review from ryon-jensen

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nasf-Fan @daosbuild1 @liw @liuxuezhao @gnailzenh