Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14152 ddb: Mismatched Dealloc Fix #12813

Merged
merged 4 commits into from
Aug 21, 2023
Merged

DAOS-14152 ddb: Mismatched Dealloc Fix #12813

merged 4 commits into from
Aug 21, 2023

Conversation

ryon-jensen
Copy link
Contributor

@ryon-jensen ryon-jensen commented Aug 9, 2023 •
edited
Loading

Test-Tag: ddb_cmd

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@ryon-jensen
DAOS-14152 ddb: Mismatched Dealloc Fix
b059a02 
Test-Tag: ddb_cmd

Required-githooks: true

Signed-off-by: Ryon Jensen <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'feature/cat_recovery: GHA build failures on warning "mismatched-dealloc"'
Status is 'In Review'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-14152

daosbuild1
daosbuild1 reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12813/1/execution/node/1096/log

daosbuild1
daosbuild1 reviewed Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

jolivier23
jolivier23 approved these changes Aug 10, 2023
View reviewed changes
src/ddb/ddb.c Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12813/2/execution/node/1096/log

kjacque
kjacque reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really prefer not to land something that will cause a coverity issue. I'd suggest creating some const at an arbitrary but large length (1024 maybe?).

src/ddb/ddb.c Outdated Show resolved Hide resolved
@ryon-jensen
From Feedback:
31ab364 
- Changed STRNDUP to use static max length, instead of strlen

Required-githooks: true

Signed-off-by: Ryon Jensen <[email protected]>
@ryon-jensen
Merge remote-tracking branch 'origin/feature/cat_recovery' into ryon-…
254d466 
…jensen/DdbFreeFix.DAOS-14152

Required-githooks: true
@ryon-jensen
Empty commit to add test tag
019772f 
Test-tag: ddb_cmd

Required-githooks: true

Signed-off-by: Ryon Jensen <[email protected]>
daosbuild1
daosbuild1 reviewed Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ryon-jensen ryon-jensen force-pushed the ryon-jensen/DdbFreeFix.DAOS-14152 branch from a4c0c3b to 019772f Compare August 11, 2023 14:45
daosbuild1
daosbuild1 reviewed Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ryon-jensen ryon-jensen requested a review from a team August 15, 2023 14:41
@ryon-jensen
Copy link
Contributor Author

ping @daos-stack/daos-gatekeeper

@mchaarawi mchaarawi merged commit 5aa02eb into feature/cat_recovery Aug 21, 2023
@mchaarawi mchaarawi deleted the ryon-jensen/DdbFreeFix.DAOS-14152 branch August 21, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@kjacque kjacque kjacque approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryon-jensen @daosbuild1 @jolivier23 @kjacque @mchaarawi